Refactoring of Cast-related crypto code

chrome/chrome_common.gypi

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # File lists shared with GN build.
     'chrome_common_sources': [
       'common/all_messages.h',
       'common/attrition_experiments.h',
@@ skipping 232 matching lines @@
       'common/service_messages.h',
       'common/service_process_util.cc',
       'common/service_process_util.h',
       'common/service_process_util_linux.cc',
       'common/service_process_util_mac.mm',
       'common/service_process_util_posix.cc',
       'common/service_process_util_posix.h',
       'common/service_process_util_win.cc',
     ],
     'chrome_common_win_mac_sources': [
-      'common/extensions/api/networking_private/networking_private_crypto_nss.cc',
-      'common/extensions/api/networking_private/networking_private_crypto_openssl.cc',
-      'common/extensions/api/networking_private/networking_private_crypto.cc',
-      'common/extensions/api/networking_private/networking_private_crypto.h',
       'common/media_galleries/itunes_library.cc',
       'common/media_galleries/itunes_library.h',
       'common/media_galleries/picasa_types.cc',
       'common/media_galleries/picasa_types.h',
       'common/media_galleries/pmp_constants.h',
     ],
+    'chrome_common_networking_private_sources_openssl' : [
+      'common/extensions/api/networking_private/networking_private_crypto_openssl.cc',
+      'common/extensions/api/networking_private/networking_private_crypto.cc',
+      'common/extensions/api/networking_private/networking_private_crypto.h',
+    ],
+    'chrome_common_networking_private_sources_nss' : [
+      'common/extensions/api/networking_private/networking_private_crypto_nss.cc',
+      'common/extensions/api/networking_private/networking_private_crypto.cc',
+      'common/extensions/api/networking_private/networking_private_crypto.h',
+    ],
+
     'chrome_common_mac_sources': [
       'common/media_galleries/iphoto_library.cc',
       'common/media_galleries/iphoto_library.h',
     ]
   },
   'targets': [
     {
       # GN: //chrome/common:common
       'target_name': 'common',
       'type': 'static_library',
@@ skipping 61 matching lines @@
             '<(DEPTH)/extensions/extensions_resources.gyp:extensions_resources',
             '<(DEPTH)/extensions/extensions_strings.gyp:extensions_strings',
           ],
           'export_dependent_settings': [
             '<(DEPTH)/chrome/common/extensions/api/api.gyp:chrome_api',
           ],
         }],
         ['OS=="win" or OS=="mac"', {
           'sources': [ '<@(chrome_common_win_mac_sources)' ],
         }],
-        ['(OS=="win" or OS=="mac") and use_openssl==1', {
-          # networking_private_crypto_openssl.cc depends on boringssl.
+        ['(OS=="win" or OS=="mac" or chromeos==1) and use_openssl==1', {

[Ryan Sleevi, 2014/12/15 21:42:59]

It's not entirely clear why the chromeos addition is correct here. Could you
explain?

[sheretov, 2014/12/16 08:44:20]

This CL moves ChromeOS to the same implementation of networkingPrivate crypto as
Windows and Mac.  Previously, ChromeOS had a different implementation that was
accessed through a D-Bus interface. The shared openssl (or nss) implementation
is contained in chrome_common_networking_private_sources_xxx.

+          'sources': [ '<@(chrome_common_networking_private_sources_openssl)' ],
           'dependencies': [
             '../third_party/boringssl/boringssl.gyp:boringssl',
           ],
         }],
+        ['(OS=="win" or OS=="mac" or chromeos==1) and use_openssl!=1', {
+          'sources': [ '<@(chrome_common_networking_private_sources_nss)' ],
+        }],
         ['OS=="mac"', {
           'sources': [ '<@(chrome_common_mac_sources)' ],
         }],
         ['OS != "ios"', {
           'dependencies': [
             '<(DEPTH)/components/components.gyp:autofill_core_common',
             '<(DEPTH)/components/components.gyp:autofill_content_common',
             '<(DEPTH)/components/components.gyp:password_manager_core_common',
             '<(DEPTH)/components/components.gyp:password_manager_content_common',
             '<(DEPTH)/components/components.gyp:signin_core_common',
@@ skipping 134 matching lines @@
             '<(DEPTH)/components/components.gyp:policy',
           ],
         }],
         ['safe_browsing==1', {
           'defines': [ 'FULL_SAFE_BROWSING' ],
           'sources': [ '<@(chrome_common_full_safe_browsing_sources)', ],
         }],
         ['safe_browsing==2', {
           'defines': [ 'MOBILE_SAFE_BROWSING' ],
         }],
-        ['use_openssl==1', {
-           'sources!': [
-             'common/extensions/api/networking_private/networking_private_crypto_nss.cc',
-           ],
-         },
-         {  # else !use_openssl
-           'sources!': [
-             'common/extensions/api/networking_private/networking_private_crypto_openssl.cc',
-           ],
-         },
-        ],
       ],
       'target_conditions': [
         ['OS == "ios"', {
           'sources/': [
             # Pull in specific Mac files for iOS (which have been filtered out
             # by file name rules).
             ['include', '^common/chrome_version_info_mac\\.mm$'],
           ],
         }],
       ],
@@ skipping 152 matching lines @@
         'common/safe_browsing/csd.proto'
       ],
       'variables': {
         'proto_in_dir': 'common/safe_browsing',
         'proto_out_dir': 'chrome/common/safe_browsing',
       },
       'includes': [ '../build/protoc.gypi' ],
     },
   ],
 }