sync/internal_api/attachments/attachment_service_proxy_unittest.cc - Issue 792343004: Standardize usage of virtual/override/final specifiers in sync/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/attachment_service_proxy_unittest.cc

Issue 792343004: Standardize usage of virtual/override/final specifiers in sync/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/attachments/attachment_service_impl_unittest.cc ('k') | sync/internal_api/attachments/attachment_store_handle_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/attachments/attachment_service_proxy_unittest.cc

diff --git a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc

index 3d5cd552888829244456edc31fc61872728a3300..d1b935637c78aed19ef03ab8eb17ca0ab69d27ce 100644

--- a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc

+++ b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc

@@ -91,7 +91,7 @@ class AttachmentServiceProxyTest : public testing::Test,

protected:

AttachmentServiceProxyTest() {}

- virtual void SetUp() {

+ void SetUp() override {

CalledOnValidThread();

stub_thread.reset(new base::Thread("attachment service stub thread"));

stub_thread->Start();

@@ -108,8 +108,7 @@ class AttachmentServiceProxyTest : public testing::Test,

count_callback_drop = 0;

}

- virtual void TearDown()

- override {

+ void TearDown() override {

// We must take care to call the stub's destructor on the stub_thread

// because that's the thread to which its WeakPtrs are bound.

if (stub) {