content/browser/android/content_view_core_impl.cc - Issue 792333004: Mousewhell on Chrome Android can scroll vertically and horizontally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 792333004: Mousewhell on Chrome Android can scroll vertically and horizontally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 281d6a459ab76fa817a11693f8da7c7581cd1042..d92fb899f6c78f9ab6b5b147c7e466ee03bfe0f1 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -954,7 +954,8 @@ jboolean ContentViewCoreImpl::SendMouseWheelEvent(JNIEnv* env,

jlong time_ms,

jfloat x,

jfloat y,

- jfloat vertical_axis) {

+ jfloat vertical_axis,

+ jfloat horizontal_axis) {

RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();

if (!rwhv)

return false;

@@ -964,6 +965,10 @@ jboolean ContentViewCoreImpl::SendMouseWheelEvent(JNIEnv* env,

direction = WebMouseWheelEventBuilder::DIRECTION_UP;

} else if (vertical_axis < 0) {

direction = WebMouseWheelEventBuilder::DIRECTION_DOWN;

+ } else if (horizontal_axis > 0) {

+ direction = WebMouseWheelEventBuilder::DIRECTION_RIGHT;

+ } else if (horizontal_axis < 0) {

+ direction = WebMouseWheelEventBuilder::DIRECTION_LEFT;

} else {

return false;

}