Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/chrome_proxy/integration_tests/network_metrics.py

Issue 792303006: Remove the net-internals dependency from chrome proxy telemetry tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit tests for the tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_proxy/integration_tests/network_metrics.py
diff --git a/tools/chrome_proxy/integration_tests/network_metrics.py b/tools/chrome_proxy/integration_tests/network_metrics.py
index 59155c9316ff10b81b688787ef24b653a9b411aa..747d60dfb2a7a12f860db5b433682e0cbcbfd94e 100644
--- a/tools/chrome_proxy/integration_tests/network_metrics.py
+++ b/tools/chrome_proxy/integration_tests/network_metrics.py
@@ -26,6 +26,9 @@ class HTTPResponse(object):
def __init__(self, event):
self._response = (
inspector_network.InspectorNetworkResponseData.FromTimelineEvent(event))
+ self._remote_port = None
+ if 'response' in event.args and 'remotePort' in event.args['response']:
+ self._remote_port = event.args['response']['remotePort']
self._content_length = None
@property
@@ -33,6 +36,10 @@ class HTTPResponse(object):
return self._response
@property
+ def remote_port(self):
+ return self._remote_port
+
+ @property
def url_signature(self):
return hashlib.md5(self.response.url).hexdigest()

Powered by Google App Engine
This is Rietveld 408576698