ui: Bubble fix

ui: Bubble fix

woops, when I was testing this, I hadn't noticed the mistake because
I was testing over a white background, and the shadow looks exactly
like the bubble in that case.

I had used the wrong color for the shadow color, and as a result I
didn't notice that the shadow was in the wrong spot.

I did a bit more extensive testing, if you have chrome fullscreen on the
left side, and you show the bubble on the right, it does extend to right
screen by 1 pixel.  This happened before and after my change.

BUG=435910
Committed: https://crrev.com/54e715bb552b75fbd91b7cec7be9d432135d9fd8
Cr-Commit-Position: refs/heads/master@{#308252}

[hendrikw, 2014-12-11 00:52:46]

hendrikw@chromium.org changed reviewers:
+ cpu@chromium.org

[hendrikw, 2014-12-11 00:54:54]

PTAL, thanks!

[cpu_(ooo_6.6-7.5), 2014-12-11 21:03:07]

lack the knowledge to review this, if it had been like a single value probably. 
try msw or pkasting please.

[hendrikw, 2014-12-11 21:21:34]

hendrikw@chromium.org changed reviewers:
+ msw@chromium.org
- cpu@chromium.org

[hendrikw, 2014-12-11 21:23:32]

hendrikw@chromium.org changed reviewers:
+ cpu@chromium.org

[hendrikw, 2014-12-11 21:24:15]

hendrikw@chromium.org changed reviewers:
- msw@chromium.org

[hendrikw, 2014-12-11 21:29:20]

hendrikw@chromium.org changed reviewers:
+ msw@chromium.org

[hendrikw, 2014-12-11 22:28:17]

hendrikw@chromium.org changed reviewers:
+ msw@chromium.org

[hendrikw, 2014-12-11 22:28:38]

On 2014/12/11 21:03:07, cpu wrote:
> lack the knowledge to review this, if it had been like a single value
probably. 
> try msw or pkasting please.

Trying msw, PTAL, thanks!

[msw, 2014-12-12 19:10:09]

https://codereview.chromium.org/792243002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/status_bubble_views.cc (right):

https://codereview.chromium.org/792243002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/status_bubble_views.cc:407: SkIntToScalar(width - 2),
SkIntToScalar(height - 2));
Should these subtract 2*StatusBubbleViews::kShadowThickness?
Make a const for that to use here and below (line 417 & 418):
  const int shadow_size = 2* kShadowThickness;

[hendrikw, 2014-12-12 23:27:18]

On 2014/12/12 19:10:09, msw wrote:
>
https://codereview.chromium.org/792243002/diff/20001/chrome/browser/ui/views/...
> File chrome/browser/ui/views/status_bubble_views.cc (right):
> 
>
https://codereview.chromium.org/792243002/diff/20001/chrome/browser/ui/views/...
> chrome/browser/ui/views/status_bubble_views.cc:407: SkIntToScalar(width - 2),
> SkIntToScalar(height - 2));
> Should these subtract 2*StatusBubbleViews::kShadowThickness?
> Make a const for that to use here and below (line 417 & 418):
>   const int shadow_size = 2* kShadowThickness;

Good point!  done.
PTAL

[msw, 2014-12-13 00:02:30]

lgtm

[hendrikw, 2014-12-13 00:03:07]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2014-12-13 00:03:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792243002/40001

[commit-bot: I haz the power, 2014-12-13 03:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-13 03:00:26]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hendrikw, 2014-12-13 04:09:06]

The CQ bit was checked by hendrikw@chromium.org

[commit-bot: I haz the power, 2014-12-13 04:09:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792243002/40001

[commit-bot: I haz the power, 2014-12-13 04:46:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-13 04:47:47]

Patchset 3 (id:??) landed as
https://crrev.com/54e715bb552b75fbd91b7cec7be9d432135d9fd8
Cr-Commit-Position: refs/heads/master@{#308252}