Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 792233006: Oilpan: remove unnecessary WeakMember friend class decl. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: remove unnecessary WeakMember friend class decl. R=kouhei BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/platform/heap/Handle.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
sof
Please take a look.
6 years ago (2014-12-17 08:28:31 UTC) #2
kouhei (in TOK)
On 2014/12/17 08:28:31, sof wrote: > Please take a look. lgtm. Thanks!
6 years ago (2014-12-17 08:33:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792233006/1
6 years ago (2014-12-17 09:11:39 UTC) #5
haraken
LGTM
6 years ago (2014-12-17 09:18:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42278)
6 years ago (2014-12-17 11:14:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792233006/1
6 years ago (2014-12-17 11:33:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42308)
6 years ago (2014-12-17 14:15:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792233006/1
6 years ago (2014-12-17 14:27:33 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-17 16:40:52 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187381

Powered by Google App Engine
This is Rietveld 408576698