Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 792233004: Invalidate Custom Scrollbars irrespective of focused frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/scrollbars/custom-scrollbar-thumb-focus-iframe-inactive-pseudo-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index f497ad9d995889ab29a3aa8445c5c8450307ce0d..1d2f7432da67e81e8ca7a4d99f5a675d08597f6f 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -1465,8 +1465,10 @@ void FrameSelection::focusedOrActiveStateChanged()
RefPtrWillBeRawPtr<Document> document = m_frame->document();
// Invalidate All CustomScrollbars as CustomScrollbars supports
- // CSS window-active attribute.
- if (FrameView* view = document->view())
+ // CSS window-active attribute.Irrespective of focus on frame, this
+ // needs to be applied for entire page. So invalidate from root FrameView
skobes 2014/12/16 22:19:52 If the frame's focus state is irrelevant, this see
MuVen 2014/12/17 17:17:15 yes, i tried earlier with what you have mentioned.
skobes 2014/12/17 17:41:31 I'm sorry, I don't understand what you're trying t
MuVen 2014/12/17 18:06:52 I have earlier tried calling focusorActiveStateCha
skobes 2014/12/17 18:51:22 I didn't mean for FocusController::setActive to ca
MuVen 2014/12/17 18:59:43 Oh ok ok !!! Got it, Make sense even. I shall upda
+ // rather than focused frame.
+ if (FrameView* view = m_frame->localFrameRoot()->document()->view())
view->invalidateAllCustomScrollbarsOnActiveChanged();
document->updateRenderTreeIfNeeded();
« no previous file with comments | « LayoutTests/scrollbars/custom-scrollbar-thumb-focus-iframe-inactive-pseudo-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698