Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 792233004: Invalidate Custom Scrollbars irrespective of focused frame. (Closed)

Created:
6 years ago by MuVen
Modified:
6 years ago
Reviewers:
pdr., skobes
CC:
blink-reviews, jdduke (slow), rune, Sikugu_, skobes
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Invalidate Custom Scrollbars irrespective of focused frame. Invalidate Custom Scrollbars irrespective of focused frame. As the CSS property indicates that custom scrollbars needs to be invalidated on losing window focus, so if the focus is on iframe element and window lost focus then the custom scrollbars of entire page needs to be invalidated to justify window-inactive property. BUG=438596 (Bug 3) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187637

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressed review comments #

Total comments: 1

Patch Set 3 : addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
A + LayoutTests/scrollbars/custom-scrollbar-thumb-focus-iframe-inactive-pseudo.html View 1 chunk +3 lines, -1 line 0 comments Download
A + LayoutTests/scrollbars/custom-scrollbar-thumb-focus-iframe-inactive-pseudo-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 29 (9 generated)
MuVen
PTAL.
6 years ago (2014-12-11 05:34:08 UTC) #2
MuVen
Rune, I have missed out this case, I have added the fix and test-case. PTAL.
6 years ago (2014-12-11 16:00:22 UTC) #3
MuVen
On 2014/12/11 16:00:22, muven wrote: > Rune, I have missed out this case, I have ...
6 years ago (2014-12-15 16:07:15 UTC) #4
MuVen
@ Skobes/Rune PTAL. Thanks, ~MuVen.
6 years ago (2014-12-16 17:55:50 UTC) #6
skobes
https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp File Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp#newcode1469 Source/core/editing/FrameSelection.cpp:1469: // needs to be applied for entire page. So ...
6 years ago (2014-12-16 22:19:52 UTC) #7
MuVen
https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp File Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp#newcode1469 Source/core/editing/FrameSelection.cpp:1469: // needs to be applied for entire page. So ...
6 years ago (2014-12-17 17:17:15 UTC) #8
skobes
https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp File Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp#newcode1469 Source/core/editing/FrameSelection.cpp:1469: // needs to be applied for entire page. So ...
6 years ago (2014-12-17 17:41:31 UTC) #9
MuVen
https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp File Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp#newcode1469 Source/core/editing/FrameSelection.cpp:1469: // needs to be applied for entire page. So ...
6 years ago (2014-12-17 18:06:52 UTC) #10
skobes
https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp File Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp#newcode1469 Source/core/editing/FrameSelection.cpp:1469: // needs to be applied for entire page. So ...
6 years ago (2014-12-17 18:51:22 UTC) #11
MuVen
https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp File Source/core/editing/FrameSelection.cpp (right): https://codereview.chromium.org/792233004/diff/1/Source/core/editing/FrameSelection.cpp#newcode1469 Source/core/editing/FrameSelection.cpp:1469: // needs to be applied for entire page. So ...
6 years ago (2014-12-17 18:59:43 UTC) #12
MuVen
PTAL. addressed as suggested by you.
6 years ago (2014-12-18 10:32:42 UTC) #13
skobes
lgtm
6 years ago (2014-12-18 19:08:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792233004/20001
6 years ago (2014-12-19 03:26:58 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/22711)
6 years ago (2014-12-19 03:34:23 UTC) #18
MuVen
@pdr, for owners stamp.
6 years ago (2014-12-22 14:56:23 UTC) #20
pdr.
LGTM https://codereview.chromium.org/792233004/diff/20001/Source/core/page/FocusController.cpp File Source/core/page/FocusController.cpp (right): https://codereview.chromium.org/792233004/diff/20001/Source/core/page/FocusController.cpp#newcode729 Source/core/page/FocusController.cpp:729: // Invalidate All CustomScrollbars as CustomScrollbars supports Please ...
6 years ago (2014-12-22 18:34:48 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792233004/40001
6 years ago (2014-12-23 05:59:33 UTC) #23
commit-bot: I haz the power
Failed to commit the patch. svn: E155010: Commit failed (details follow): svn: E155010: '/b/infra_internal/commit_queue/workdir/blink/LayoutTests/virtual/slimmingpaint/svg' is ...
6 years ago (2014-12-23 07:09:38 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792233004/40001
6 years ago (2014-12-23 07:10:42 UTC) #28
commit-bot: I haz the power
6 years ago (2014-12-23 07:11:26 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187637

Powered by Google App Engine
This is Rietveld 408576698