Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 792233002: Instrumenting IOComplete internals to find jank. (Closed)

Created:
6 years ago by vadimt
Modified:
6 years ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumenting IOComplete internals to find jank. Instrumenting IOComplete internals to find jank. From prior instrumentations, the jank turned to be in QuicStreamFactory::Job::OnIOComplete - 26 jps and TransportConnectJobHelper::OnIOComplete - 7 jph Instrumentation of the callback of QuicStreamFactory::Job::OnIOComplete is covered by CL https://codereview.chromium.org/789483004/. This CL instruments the rest. BUG=436634 Committed: https://crrev.com/da2e8a634f21c417d78a549d873c49ce7e7d1452 Cr-Commit-Position: refs/heads/master@{#308096}

Patch Set 1 #

Total comments: 2

Patch Set 2 : mmenke@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M net/socket/client_socket_pool_base.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
vadimt
mmenke@, please review
6 years ago (2014-12-10 23:59:04 UTC) #2
mmenke
https://codereview.chromium.org/792233002/diff/1/net/quic/quic_stream_factory.cc File net/quic/quic_stream_factory.cc (right): https://codereview.chromium.org/792233002/diff/1/net/quic/quic_stream_factory.cc#newcode305 net/quic/quic_stream_factory.cc:305: "436634 QuicStreamFactory::Job::OnIOComplete1")); This is done in the other CL, ...
6 years ago (2014-12-11 20:00:38 UTC) #3
vadimt
https://codereview.chromium.org/792233002/diff/1/net/quic/quic_stream_factory.cc File net/quic/quic_stream_factory.cc (right): https://codereview.chromium.org/792233002/diff/1/net/quic/quic_stream_factory.cc#newcode305 net/quic/quic_stream_factory.cc:305: "436634 QuicStreamFactory::Job::OnIOComplete1")); On 2014/12/11 20:00:38, mmenke wrote: > This ...
6 years ago (2014-12-11 20:22:26 UTC) #4
mmenke
LGTM
6 years ago (2014-12-12 15:20:26 UTC) #5
mmenke
LGTM
6 years ago (2014-12-12 15:20:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792233002/20001
6 years ago (2014-12-12 15:21:57 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 16:21:56 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-12 16:23:30 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da2e8a634f21c417d78a549d873c49ce7e7d1452
Cr-Commit-Position: refs/heads/master@{#308096}

Powered by Google App Engine
This is Rietveld 408576698