Remove webkit_glue::BuildUserAgent(), remove windows spoofing

content/common/content_client.h

Index: content/common/content_client.h
diff --git a/content/common/content_client.h b/content/common/content_client.h
index 9f5521fee2c54382832cb8e7cd9067f3e89bbc33..fc252384a8f00678b62bc2505116d016655e0c19 100644
--- a/content/common/content_client.h
+++ b/content/common/content_client.h
@@ -76,10 +76,9 @@ class CONTENT_EXPORT ContentClient {
   // behalf of a swapped out renderer.
   virtual bool CanHandleWhileSwappedOut(const IPC::Message& msg) = 0;
 
-  // Returns the user agent. If mimic_windows is true then the embedder can
-  // return a fake Windows user agent. This is a workaround for broken
-  // websites.
-  virtual std::string GetUserAgent(bool mimic_windows) const = 0;
+  // Returns the user agent and indicates whether this string should
+  // always be used (overriding any hacks to work around browser sniffing).
+  virtual std::string GetUserAgent(bool *overriding) const = 0;

[Evan Martin, 2011/09/21 20:27:24]

star on the left

I don't quite get the doc: when overriding is true, it's saying I should always
obey the returned user agent?  As opposed to it being optional?

[Dirk Pranke, 2011/09/21 21:02:35]

That is correct. I will attempt to make it clearer, but suggestions are welcome.

 
   // Returns a string resource given its id.
   virtual string16 GetLocalizedString(int message_id) const = 0;