Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
792183002:
Put more information into device status json output. (Closed)
DescriptionPut more information into device status json output.
BUG=440939
R=navabi@chromium.org
Committed: https://crrev.com/e2a338fac902ff391f761c67580b8de00d4adfdf
Cr-Commit-Position: refs/heads/master@{#308392}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Rebase master #Messages
Total messages: 18 (6 generated)
ptal
navabi@google.com changed reviewers: + navabi@google.com
https://codereview.chromium.org/792183002/diff/1/build/android/buildbot/bb_de... File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/792183002/diff/1/build/android/buildbot/bb_de... build/android/buildbot/bb_device_status_check.py:377: f.write(json.dumps(json_data, indent=4)) I guess you've verified no one uses the old json dump, with offline devices, unique types, etc, since this one does not have the same information.
On 2014/12/10 23:06:28, navabi wrote: > https://codereview.chromium.org/792183002/diff/1/build/android/buildbot/bb_de... > File build/android/buildbot/bb_device_status_check.py (right): > > https://codereview.chromium.org/792183002/diff/1/build/android/buildbot/bb_de... > build/android/buildbot/bb_device_status_check.py:377: > f.write(json.dumps(json_data, indent=4)) > I guess you've verified no one uses the old json dump, with offline devices, > unique types, etc, since this one does not have the same information. Correct, I added the json output option in the first place and we never got a chance to make use of it:(
lgtm
lgtm
The CQ bit was checked by zty@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792183002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/98607) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by zty@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792183002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/98946) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by zty@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792183002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e2a338fac902ff391f761c67580b8de00d4adfdf Cr-Commit-Position: refs/heads/master@{#308392} |
