Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 792173002: Revert of Implement HasPermission() method in PermissionService. (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Miguel Garcia
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement HasPermission() method in PermissionService. (patchset #28 id:580001 of https://codereview.chromium.org/750633003/) Reason for revert: This still causes build failures, I just got this locally: ninja -C out/Release/ chrome ninja: Entering directory `out/Release/' [46/16655] CXX obj/content/public/app/content_app_both.content_main_delegate.o FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/public/app/content_app_both.content_main_delegate.o.d -DCONTENT_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DDISABLE_NACL -DCHROMIUM_BUILD -DCR_CLANG_REVISION=218707 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DMOJO_USE_SYSTEM_IMPL -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_IGNORE_GPU_LAYER_HOISTING -DSK_SUPPORT_LEGACY_NewRasterPMColor -DSK_USE_POSIX_THREADS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/WebKit -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -O2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wexit-time-destructors -std=c++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/MacintoshHD2/src/chromefetch/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -c ../../content/public/app/content_main_delegate.cc -o obj/content/public/app/content_app_both.content_main_delegate.o In file included from ../../content/public/app/content_main_delegate.cc:8: ../../content/public/browser/content_browser_client.h:22:10: fatal error: 'content/public/common/permission_status.mojom.h' file not found #include "content/public/common/permission_status.mojom.h" ^ 1 error generated. [46/16655] CXX obj/content/app/content_app_both.content_main_runner.o FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/app/content_app_both.content_main_runner.o.d -DCONTENT_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DDISABLE_NACL -DCHROMIUM_BUILD -DCR_CLANG_REVISION=218707 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DMOJO_USE_SYSTEM_IMPL -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_IGNORE_GPU_LAYER_HOISTING -DSK_SUPPORT_LEGACY_NewRasterPMColor -DSK_USE_POSIX_THREADS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/WebKit -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -O2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch x86_64 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wexit-time-destructors -std=c++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/MacintoshHD2/src/chromefetch/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -c ../../content/app/content_main_runner.cc -o obj/content/app/content_app_both.content_main_runner.o In file included from ../../content/app/content_main_runner.cc:36: ../../content/public/browser/content_browser_client.h:22:10: fatal error: 'content/public/common/permission_status.mojom.h' file not found #include "content/public/common/permission_status.mojom.h" ^ 1 error generated. Original issue's description: > Implement HasPermission() method in PermissionService. > > This patch implements the HasPermission() method in the mojo PermissionService. > This methiod will be required for the Permissions API, see > https://w3c.github.io/permissions/ > > BUG=430238 > > Committed: https://crrev.com/277b23d74855b51ebe67ae0da7cd9e0b053044cf > Cr-Commit-Position: refs/heads/master@{#307302} > > Committed: https://crrev.com/14570267ac4d5dc473d29f256e8d044e9bfcc8d2 > Cr-Commit-Position: refs/heads/master@{#307504} TBR=mlamouri@chromium.org,qsr@chromium.org,blundell@chromium.org,tsepez@chromium.org,avi@chromium.org,timvolodine@chromium.org NOTREECHECKS=true NOTRY=true BUG=430238 Committed: https://crrev.com/ea4b5a8eb8f66713482ef7f4a8aca83886965440 Cr-Commit-Position: refs/heads/master@{#307766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -182 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -61 lines 0 comments Download
D content/browser/permissions/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/permissions/permission_service_context.h View 4 chunks +0 lines, -6 lines 0 comments Download
M content/browser/permissions/permission_service_context.cc View 3 chunks +1 line, -23 lines 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 1 chunk +1 line, -10 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/permission_service.mojom View 1 chunk +5 lines, -1 line 0 comments Download
M content/content.gyp View 5 chunks +9 lines, -0 lines 0 comments Download
M content/content_app.gypi View 2 chunks +5 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -37 lines 0 comments Download
A content/content_common_mojo_bindings.gypi View 1 chunk +36 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/common/permission_status.mojom View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Implement HasPermission() method in PermissionService.
6 years ago (2014-12-10 21:27:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792173002/1
6 years ago (2014-12-10 21:28:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-10 21:29:24 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-10 21:30:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea4b5a8eb8f66713482ef7f4a8aca83886965440
Cr-Commit-Position: refs/heads/master@{#307766}

Powered by Google App Engine
This is Rietveld 408576698