Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: components/browser_watcher/exit_funnel_win_unittest.cc

Issue 792163002: Add ExitFunnel to prepare for instrumenting browser exits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Remove stray files. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/exit_funnel_win_unittest.cc
diff --git a/components/browser_watcher/exit_funnel_win_unittest.cc b/components/browser_watcher/exit_funnel_win_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..58bca924834cfa456f2092fe027424859d1951d4
--- /dev/null
+++ b/components/browser_watcher/exit_funnel_win_unittest.cc
@@ -0,0 +1,115 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/browser_watcher/exit_funnel_win.h"
+
+#include <map>
+
+#include "base/command_line.h"
+#include "base/process/process_handle.h"
+#include "base/strings/string16.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/stringprintf.h"
+#include "base/test/test_reg_util_win.h"
+#include "base/threading/platform_thread.h"
+#include "base/time/time.h"
+#include "base/win/registry.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace browser_watcher {
+
+namespace {
+
+const wchar_t kRegistryPath[] = L"Software\\ExitFunnelWinTest";
+
+class ExitFunnelWinTest : public testing::Test {
+ public:
+ typedef testing::Test Super;
+ typedef std::map<base::string16, int64> EventMap;
+
+ virtual void SetUp() override {
+ Super::SetUp();
+
+ override_manager_.OverrideRegistry(HKEY_CURRENT_USER);
+ }
+
+ base::string16 GetEventSubkey() {
+ // There should be a single subkey named after this process' pid.
+ base::win::RegistryKeyIterator it(HKEY_CURRENT_USER, kRegistryPath);
+ EXPECT_EQ(1, it.SubkeyCount());
+
+ unsigned pid = 0;
+ base::StringToUint(it.Name(), &pid);
+ EXPECT_EQ(base::GetCurrentProcId(), pid);
+
+ return it.Name();
+ }
+
+ EventMap ReadEventsFromSubkey(const base::string16& subkey_name) {
+ base::string16 key_name(
+ base::StringPrintf(L"%ls\\%ls", kRegistryPath, subkey_name.c_str()));
erikwright (departed) 2014/12/11 15:00:46 It really seems like there should be a single impl
Sigurður Ásgeirsson 2014/12/12 16:21:40 The behavior is subtly different, and in any case
+
+ base::win::RegKey key(HKEY_CURRENT_USER, key_name.c_str(), KEY_READ);
+ EXPECT_TRUE(key.Valid());
+ EXPECT_EQ(2, key.GetValueCount());
+
+ EventMap events;
+ for (size_t i = 0; i < key.GetValueCount(); ++i) {
+ base::string16 name;
+ EXPECT_EQ(key.GetValueNameAt(i, &name), ERROR_SUCCESS);
+ int64 value = 0;
+ EXPECT_EQ(key.ReadInt64(name.c_str(), &value), ERROR_SUCCESS);
+
+ events[name] = value;
+ }
+
+ return events;
+ }
+
+ EventMap ReadEvents() {
+ base::string16 name = GetEventSubkey();
+ return ReadEventsFromSubkey(name);
+ }
+
+ protected:
+ registry_util::RegistryOverrideManager override_manager_;
+};
+
+} // namespace
+
+TEST_F(ExitFunnelWinTest, RecordSingleEvent) {
+ // Record a couple of events.
+ ASSERT_TRUE(ExitFunnel::RecordSingleEvent(kRegistryPath, L"One"));
+ ASSERT_TRUE(ExitFunnel::RecordSingleEvent(kRegistryPath, L"Two"));
+
+ EventMap events = ReadEvents();
+
+ ASSERT_EQ(events.size(), 2);
+ ASSERT_TRUE(events.find(L"One") != events.end());
+ ASSERT_TRUE(events.find(L"Two") != events.end());
+}
+
+TEST_F(ExitFunnelWinTest, RecordsEventTimes) {
+ ExitFunnel funnel;
+
+ ASSERT_TRUE(funnel.Init(kRegistryPath, base::GetCurrentProcessHandle()));
+ ASSERT_TRUE(funnel.RecordEvent(L"One"));
+
+ // Sleep for half a second to space the events in time.
+ base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(500));
+
+ ASSERT_TRUE(funnel.RecordEvent(L"Two"));
+
+ EventMap events = ReadEvents();
+ ASSERT_EQ(events.size(), 2);
+
+ base::TimeDelta one = base::TimeDelta::FromInternalValue(events[L"One"]);
+ base::TimeDelta two = base::TimeDelta::FromInternalValue(events[L"Two"]);
+
+ // Sleep is not accurate, it may over or under sleep. To minimize flakes,
+ // this test only compares relative ordering of the events.
+ ASSERT_LT(one, two);
+}
+
+} // namespace browser_watcher

Powered by Google App Engine
This is Rietveld 408576698