Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: components/browser_watcher/watcher_metrics_provider_win.h

Issue 792163002: Add ExitFunnel to prepare for instrumenting browser exits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Address Erik's comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/watcher_metrics_provider_win.h
diff --git a/components/browser_watcher/watcher_metrics_provider_win.h b/components/browser_watcher/watcher_metrics_provider_win.h
index d5a03e434c2ae6f7bb3abd5bc8fae125c5a1d52c..d2a47545a5677375d5278de2897e6b97981de1a2 100644
--- a/components/browser_watcher/watcher_metrics_provider_win.h
+++ b/components/browser_watcher/watcher_metrics_provider_win.h
@@ -12,10 +12,20 @@
namespace browser_watcher {
// Provides stability data captured by the Chrome Watcher, namely the browser
-// process exit codes.
+// process exit codes, as well as exit funnel metrics.
+// The exit funnel records a trace of named, timed events in registry per
+// process. For reporting, the trace is recorded as a sequence of events
+// named Stability.ExitFunnel.<eventname>, associated to the time
+// (in milliseconds) from first event in a trace. For a normal process exit,
+// the sequence might look like this:
+// - Stability.ExitFunnel.Logoff: 0
+// - Stability.ExitFunnel.NotifyShutdown: 10
+// - Stability.ExitFunnel.EndSession: 20
+// - Stability.ExitFunnel.KillProcess: 30
class WatcherMetricsProviderWin : public metrics::MetricsProvider {
public:
static const char kBrowserExitCodeHistogramName[];
+ static const char kExitFunnelHistogramPrefix[];
explicit WatcherMetricsProviderWin(const base::char16* registry_path);
~WatcherMetricsProviderWin();
« no previous file with comments | « components/browser_watcher/exit_funnel_win_unittest.cc ('k') | components/browser_watcher/watcher_metrics_provider_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698