Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 792143003: cc: Use GetSize instead of recorded_viewport_ (Closed)

Created:
6 years ago by hendrikw
Modified:
6 years ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Use GetSize instead of recorded_viewport_ recorded_viewport_ doesn't always reflect the layer size, and as a result the solid color analysis wasn't being run correctly when recorded_viewport_ was cleared. BUG=435187 Committed: https://crrev.com/b193304472fadfde1563c3cbbb825ad9ca89f9ce Cr-Commit-Position: refs/heads/master@{#307841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M cc/resources/display_list_recording_source.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/resources/picture_pile.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
hendrikw
PTAL, thanks!
6 years ago (2014-12-10 22:04:18 UTC) #2
enne (OOO)
lgtm
6 years ago (2014-12-10 22:06:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792143003/1
6 years ago (2014-12-10 22:13:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/36388)
6 years ago (2014-12-11 00:12:41 UTC) #7
hendrikw
On 2014/12/11 00:12:41, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years ago (2014-12-11 01:30:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792143003/1
6 years ago (2014-12-11 01:34:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 02:25:36 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-11 02:26:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b193304472fadfde1563c3cbbb825ad9ca89f9ce
Cr-Commit-Position: refs/heads/master@{#307841}

Powered by Google App Engine
This is Rietveld 408576698