Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: Source/core/dom/NodeRareData.cpp

Issue 792083006: replace COMPILE_ASSERT with static_assert in core/dom/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/dom/QualifiedName.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 26 matching lines...) Expand all
37 #include "platform/heap/Handle.h" 37 #include "platform/heap/Handle.h"
38 38
39 namespace blink { 39 namespace blink {
40 40
41 struct SameSizeAsNodeRareData { 41 struct SameSizeAsNodeRareData {
42 void* m_pointer[2]; 42 void* m_pointer[2];
43 OwnPtrWillBeMember<NodeMutationObserverData> m_mutationObserverData; 43 OwnPtrWillBeMember<NodeMutationObserverData> m_mutationObserverData;
44 unsigned m_bitfields; 44 unsigned m_bitfields;
45 }; 45 };
46 46
47 COMPILE_ASSERT(sizeof(NodeRareData) == sizeof(SameSizeAsNodeRareData), NodeRareD ataShouldStaySmall); 47 static_assert(sizeof(NodeRareData) == sizeof(SameSizeAsNodeRareData), "NodeRareD ata should stay small");
48 48
49 void NodeRareData::traceAfterDispatch(Visitor* visitor) 49 void NodeRareData::traceAfterDispatch(Visitor* visitor)
50 { 50 {
51 #if ENABLE(OILPAN) 51 #if ENABLE(OILPAN)
52 visitor->trace(m_renderer); 52 visitor->trace(m_renderer);
53 #endif 53 #endif
54 visitor->trace(m_mutationObserverData); 54 visitor->trace(m_mutationObserverData);
55 // Do not keep empty NodeListsNodeData objects around. 55 // Do not keep empty NodeListsNodeData objects around.
56 if (m_nodeLists && m_nodeLists->isEmpty()) 56 if (m_nodeLists && m_nodeLists->isEmpty())
57 m_nodeLists.clear(); 57 m_nodeLists.clear();
(...skipping 15 matching lines...) Expand all
73 if (m_isElementRareData) 73 if (m_isElementRareData)
74 static_cast<ElementRareData*>(this)->~ElementRareData(); 74 static_cast<ElementRareData*>(this)->~ElementRareData();
75 else 75 else
76 this->~NodeRareData(); 76 this->~NodeRareData();
77 } 77 }
78 78
79 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow 79 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow
80 static_assert(FrameHost::maxNumberOfFrames < (1 << NodeRareData::ConnectedFrameC ountBits), "Frame limit should fit in rare data count"); 80 static_assert(FrameHost::maxNumberOfFrames < (1 << NodeRareData::ConnectedFrameC ountBits), "Frame limit should fit in rare data count");
81 81
82 } // namespace blink 82 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/dom/QualifiedName.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698