Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: pkg/analysis_server/lib/src/domain_server.dart

Issue 792053002: Code clean-up (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_server.dart
diff --git a/pkg/analysis_server/lib/src/domain_server.dart b/pkg/analysis_server/lib/src/domain_server.dart
index bdd22662f9d28ee6fdb3ad4ecac866096634ff90..607fb3da89b927db1489e7c093d945f961855d07 100644
--- a/pkg/analysis_server/lib/src/domain_server.dart
+++ b/pkg/analysis_server/lib/src/domain_server.dart
@@ -58,59 +58,6 @@ class ServerDomainHandler implements RequestHandler {
return new ServerSetSubscriptionsResult().toResponse(request.id);
}
- // TODO(scheglov) remove or move to the 'analysis' domain
-// /**
-// * Create a new context in which analysis can be performed. The context that
-// * is created will persist until server.deleteContext is used to delete it.
-// * Clients, therefore, are responsible for managing the lifetime of contexts.
-// */
-// Response createContext(Request request) {
-// String sdkDirectory = request.getRequiredParameter(SDK_DIRECTORY_PARAM).asString();
-// Map<String, String> packageMap = request.getParameter(PACKAGE_MAP_PARAM, {}).asStringMap();
-//
-// String contextId = request.getRequiredParameter(AnalysisServer.CONTEXT_ID_PARAM).asString();
-// if (server.contextMap.containsKey(contextId)) {
-// return new Response.contextAlreadyExists(request);
-// }
-// AnalysisContext context = AnalysisEngine.instance.createAnalysisContext();
-// // TODO(brianwilkerson) Use the information from the request to set the
-// // source factory in the context.
-// DirectoryBasedDartSdk sdk;
-// try {
-// sdk = new DirectoryBasedDartSdk(new JavaFile(sdkDirectory));
-// } on Exception catch (e) {
-// // TODO what error code should be returned here?
-// return new Response(request.id, new RequestError(
-// RequestError.CODE_SDK_ERROR, 'Failed to access sdk: $e'));
-// }
-// context.sourceFactory = new SourceFactory([
-// new DartUriResolver(sdk),
-// new FileUriResolver(),
-// // new PackageUriResolver(),
-// ]);
-// server.contextMap[contextId] = context;
-// server.contextIdMap[context] = contextId;
-//
-// Response response = new Response(request.id);
-// return response;
-// }
-//
-// /**
-// * Delete the context with the given id. Future attempts to use the context id
-// * will result in an error being returned.
-// */
-// Response deleteContext(Request request) {
-// String contextId = request.getRequiredParameter(AnalysisServer.CONTEXT_ID_PARAM).asString();
-//
-// AnalysisContext removedContext = server.contextMap.remove(contextId);
-// if (removedContext == null) {
-// return new Response.contextDoesNotExist(request);
-// }
-// server.contextIdMap.remove(removedContext);
-// Response response = new Response(request.id);
-// return response;
-// }
-
/**
* Cleanly shutdown the analysis server.
*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698