Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 792043007: [turbofan] Add frame state to the PlainPrimitiveToNumber unit test. (Closed)

Created:
5 years, 11 months ago by Jarin
Modified:
5 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add frame state to the PlainPrimitiveToNumber unit test. R=mstarzinger@chromium.org Committed: https://crrev.com/2e4e43a2dc3173540d174c8b98e565cb2d5e0c3c Cr-Commit-Position: refs/heads/master@{#26113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 11 months ago (2015-01-16 14:17:26 UTC) #1
Michael Starzinger
LGTM.
5 years, 11 months ago (2015-01-16 14:27:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792043007/1
5 years, 11 months ago (2015-01-16 14:29:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 22:21:12 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 22:21:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e4e43a2dc3173540d174c8b98e565cb2d5e0c3c
Cr-Commit-Position: refs/heads/master@{#26113}

Powered by Google App Engine
This is Rietveld 408576698