android: Add entry for 'skia_unittests' to UNIT_TESTS list.

android: Add entry for 'skia_unittests' to UNIT_TESTS list.

That way android_dbg_tests_recipe will be able to run skia_unittests
target.

BUG=444058
R=luqui@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293602

[tfarina, 2014-12-30 23:47:49]

Depends on https://codereview.chromium.org/815023003/.

PTAL

[luqui, 2015-01-06 21:54:10]

luqui@chromium.org changed reviewers:
+ jam@chromium.org

[luqui, 2015-01-06 21:54:11]

Sorry this slipped through the cracks for a week.

android_dbg_tests_recipe is very time-sensitive, and we are hesitant to do
anything that would make it take longer.  Please check with +jam about this.

[danakj, 2015-01-06 21:59:02]

These tests already run in unit_tests, this should help make it faster by
allowing more targetting choice of tests by the bots.

On Tue, Jan 6, 2015 at 1:54 PM, <luqui@chromium.org> wrote:

> Sorry this slipped through the cracks for a week.
>
> android_dbg_tests_recipe is very time-sensitive, and we are hesitant to do
> anything that would make it take longer.  Please check with +jam about
> this.
>
> https://codereview.chromium.org/792043006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-01-12 14:30:39]

It has landed in Chromium
https://chromium.googlesource.com/chromium/src.git/+/0f9c5eed19153d16a29a2063...

Luqui, could you or John approve this?

[jam, 2015-01-12 17:06:02]

On 2015/01/06 21:59:02, danakj wrote:
> These tests already run in unit_tests, this should help make it faster by
> allowing more targetting choice of tests by the bots.

lgtm

thanks luqui for the vigilance towards the run time of this bot :)

> 
> On Tue, Jan 6, 2015 at 1:54 PM, <mailto:luqui@chromium.org> wrote:
> 
> > Sorry this slipped through the cracks for a week.
> >
> > android_dbg_tests_recipe is very time-sensitive, and we are hesitant to do
> > anything that would make it take longer.  Please check with +jam about
> > this.
> >
> > https://codereview.chromium.org/792043006/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-01-12 18:17:22]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-01-12 18:17:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792043006/1

[commit-bot: I haz the power, 2015-01-12 18:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-12 18:20:07]

Presubmit check for 792043006-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
scripts/slave/unittests/recipe_simulation_test.py (25.81s) failed
.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F............F.........F....F........F.....F................................................................................................................................

======================================================================
FAIL: android/tester.no_provision_devices_when_no_tests
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/android/tester.expected/no_provision_devices_when_no_tests.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 102,110 ****
   {'cmd': ['python',
            '-u',
            '[SLAVE_BUILD]/src/build/gyp_chromium',
            '--analyzer',
!           '{"files": ["foo.cc"], "targets": ["android_webview_test_apk",
"chrome_shell_test_apk", "content_shell_test_apk", "chrome_sync_shell_test_apk",
"android_webview_unittests", "base_unittests", "breakpad_unittests",
"cc_unittests", "components_unittests", "content_browsertests",
"content_unittests", "events_unittests", "gl_tests", "gpu_unittests",
"ipc_tests", "media_unittests", "net_unittests", "sandbox_linux_unittests",
"sql_unittests", "sync_unit_tests", "ui_android_unittests", "ui_base_unittests",
"ui_touch_selection_unittests", "unit_tests", "junit_unit_tests"]}',
            '/path/to/tmp/json'],
    'env': {'GYP_CROSSCOMPILE': '1',
            'GYP_DEFINES': "OS=android component=static_library fastbuild=1
gomadir='[BUILD]/goma' target_arch=arm use_goma=1"},
    'name': 'analyze',
--- 102,110 ----
   {'cmd': ['python',
            '-u',
            '[SLAVE_BUILD]/src/build/gyp_chromium',
            '--analyzer',
!           '{"files": ["foo.cc"], "targets": ["android_webview_test_apk",
"chrome_shell_test_apk", "content_shell_test_apk", "chrome_sync_shell_test_apk",
"android_webview_unittests", "base_unittests", "breakpad_unittests",
"cc_unittests", "components_unittests", "content_browsertests",
"content_unittests", "events_unittests", "gl_tests", "gpu_unittests",
"ipc_tests", "media_unittests", "net_unittests", "sandbox_linux_unittests",
"skia_unittests", "sql_unittests", "sync_unit_tests", "ui_android_unittests",
"ui_base_unittests", "ui_touch_selection_unittests", "unit_tests",
"junit_unit_tests"]}',
            '/path/to/tmp/json'],
    'env': {'GYP_CROSSCOMPILE': '1',
            'GYP_DEFINES': "OS=android component=static_library fastbuild=1
gomadir='[BUILD]/goma' target_arch=arm use_goma=1"},
    'name': 'analyze',

======================================================================
FAIL: android/tester.no_compile_because_of_analyze
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/android/tester.expected/no_compile_because_of_analyze.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 102,110 ****
   {'cmd': ['python',
            '-u',
            '[SLAVE_BUILD]/src/build/gyp_chromium',
            '--analyzer',
!           '{"files": ["foo.cc"], "targets": ["android_webview_test_apk",
"chrome_shell_test_apk", "content_shell_test_apk", "chrome_sync_shell_test_apk",
"android_webview_unittests", "base_unittests", "breakpad_unittests",
"cc_unittests", "components_unittests", "content_browsertests",
"content_unittests", "events_unittests", "gl_tests", "gpu_unittests",
"ipc_tests", "media_unittests", "net_unittests", "sandbox_linux_unittests",
"sql_unittests", "sync_unit_tests", "ui_android_unittests", "ui_base_unittests",
"ui_touch_selection_unittests", "unit_tests", "junit_unit_tests"]}',
            '/path/to/tmp/json'],
    'env': {'GYP_CROSSCOMPILE': '1',
            'GYP_DEFINES': "OS=android component=static_library fastbuild=1
gomadir='[BUILD]/goma' target_arch=arm use_goma=1"},
    'name': 'analyze',
--- 102,110 ----
   {'cmd': ['python',
            '-u',
            '[SLAVE_BUILD]/src/build/gyp_chromium',
            '--analyzer',
!           '{"files": ["foo.cc"], "targets": ["android_webview_test_apk",
"chrome_shell_test_apk", "content_shell_test_apk", "chrome_sync_shell_test_apk",
"android_webview_unittests", "base_unittests", "breakpad_unittests",
"cc_unittests", "components_unittests", "content_browsertests",
"content_unittests", "events_unittests", "gl_tests", "gpu_unittests",
"ipc_tests", "media_unittests", "net_unittests", "sandbox_linux_unittests",
"skia_unittests", "sql_unittests", "sync_unit_tests", "ui_android_unittests",
"ui_base_unittests", "ui_touch_selection_unittests", "unit_tests",
"junit_unit_tests"]}',
            '/path/to/tmp/json'],
    'env': {'GYP_CROSSCOMPILE': '1',
            'GYP_DEFINES': "OS=android component=static_library fastbuild=1
gomadir='[BUILD]/goma' target_arch=arm use_goma=1"},
    'name': 'analyze',

======================================================================
FAIL: android/tester.android_dbg_tests_recipe__content_browsertests_failure
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe__content_browsertests_failure.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 102,110 ****
   {'cmd': ['python',
            '-u',
            '[SLAVE_BUILD]/src/build/gyp_chromium',
            '--analyzer',
!           '{"files": ["foo.cc"], "targets": ["android_webview_test_apk",
"chrome_shell_test_apk", "content_shell_test_apk", "chrome_sync_shell_test_apk",
"android_webview_unittests", "base_unittests", "breakpad_unittests",
"cc_unittests", "components_unittests", "content_browsertests",
"content_unittests", "events_unittests", "gl_tests", "gpu_unittests",
"ipc_tests", "media_unittests", "net_unittests", "sandbox_linux_unittests",
"sql_unittests", "sync_unit_tests", "ui_android_unittests", "ui_base_unittests",
"ui_touch_selection_unittests", "unit_tests", "junit_unit_tests"]}',
            '/path/to/tmp/json'],
    'env': {'GYP_CROSSCOMPILE': '1',
            'GYP_DEFINES': "OS=android component=static_library fastbuild=1
gomadir='[BUILD]/goma' target_arch=arm use_goma=1"},
    'name': 'analyze',
--- 102,110 ----
   {'cmd': ['python',
            '-u',
            '[SLAVE_BUILD]/src/build/gyp_chromium',
            '--analyzer',
!           '{"files": ["foo.cc"], "targets": ["android_webview_test_apk",
"chrome_shell_test_apk", "content_shell_test_apk", "chrome_sync_shell_test_apk",
"android_webview_unittests", "base_unittests", "breakpad_unittests",
"cc_unittests", "components_unittests", "content_browsertests",
"content_unittests", "events_unittests", "gl_tests", "gpu_unittests",
"ipc_tests", "media_unittests", "net_unittests", "sandbox_linux_unittests",
"skia_unittests", "sql_unittests", "sync_unit_tests", "ui_android_unittests",
"ui_base_unittests", "ui_touch_selection_unittests", "unit_tests",
"junit_unit_tests"]}',
            '/path/to/tmp/json'],
    'env': {'GYP_CROSSCOMPILE': '1',
            'GYP_DEFINES': "OS=android component=static_library fastbuild=1
gomadir='[BUILD]/goma' target_arch=arm use_goma=1"},
    'name': 'analyze',

======================================================================
FAIL: android/tester.tryserver_chromium_linux_android_dbg_tests_recipe
(/b/infra_internal/commit_queue/workdir/tools/build/scripts/slave/recipes/android/tester.expected/tryserver_chromium_linux_android_dbg_tests_recipe.json)
----------------------------------------------------------------------
*** expected
--- current
***************
*** 102,110 ****
   {'cmd': ['python',
            '-u',
            '[SLAVE_BUILD]/src/build/gyp_chromium',
            '--analyzer',
!           '{"files": ["foo.cc"], "targets": ["android_webview_test_apk",
"chrome_shell_test_apk", "content_shell_test_apk", "chrome_sync_shell_test_apk",
"android_webview_unittests", "base_unittests", "breakpad_unittests",
"cc_unittests", "components_unittests", "content_browsertests",
"content_unittests", "events_unittests", "gl_tests", "gpu_unittests",
"ipc_tests", "media_unittests", "net_unittests", "sandbox_linux_unittests",
"sql_unittests", "sync_unit_tests", "ui_android_unittests", "ui_base_unittests",
"ui_touch_selection_unittests", "unit_tests", "junit_unit_tests"]}',
            '/path/to/tmp/json'],
    'env': {'GYP_CROSSCOMPILE': '1',
            'GYP_DEFINES': "OS=android component=static_library fastbuild=1
gomadir='[BUILD]/goma' target_arch=arm use_goma=1"},
    'name': 'analyze',
--- 102,110 ----
   {'cmd': ['python',
            '-u',
            '[SLAVE_BUILD]/src/build/gyp_chromium',
            '--analyzer',
!           '{"files": ["foo.cc"], "targets": ["android_webview_test_apk",
"chrome_shell_test_apk", "content_shell_test_apk", "chrome_sync_shell_test_apk",
"android_webview_unittests", "base_unittests", "breakpad_unittests",
"cc_unittests", "components_unittests", "content_browsertests",
"content_unittests", "events_unittests", "gl_tests", "gpu_unittest…
(message too large)

[tfarina, 2015-01-12 18:30:37]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-01-12 18:30:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792043006/20001

[commit-bot: I haz the power, 2015-01-12 18:33:27]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293602

[jbudorick, 2015-01-13 01:06:52]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/846073004/ by jbudorick@chromium.org.

The reason for reverting is: These are consistently failing on
android_dbg_tests_recipe. Reproduced locally -- they appear to crash immediately
when running with --gtest-list-tests, so we don't get past that point. (The test
scripts aren't doing a great job of communicating that crash, but they aren't to
blame.).