gin/array_buffer.cc - Issue 79203004: [Gin] Add a mechanism for wrapping C++ object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/array_buffer.cc

Issue 79203004: [Gin] Add a mechanism for wrapping C++ object (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/array_buffer.cc

diff --git a/gin/array_buffer.cc b/gin/array_buffer.cc

index 9f93bf94514656e896c8e853d8871d49d5fb6c81..8b533540247bbd915cbf65c1b398427c710e63ee 100644

--- a/gin/array_buffer.cc

+++ b/gin/array_buffer.cc

@@ -107,7 +107,7 @@ void ArrayBuffer::Private::WeakCallback(

const v8::WeakCallbackData<v8::ArrayBuffer, Private>& data) {

Private* parameter = data.GetParameter();

parameter->array_buffer_.Reset();

- // parameter->self_reference_.clear();

+ parameter->self_reference_ = NULL;

abarth-chromium 2013/11/21 02:53:43 I can make this change in a separate CL if you pre

}

// ArrayBuffer ----------------------------------------------------------------

« no previous file with comments | « no previous file | gin/dictionary.cc » ('j') | gin/dictionary.cc » ('J')