Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2013 The Chromium Authors. All rights reserved. | 1 // Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "gin/dictionary.h" | 5 #include "gin/dictionary.h" |
| 6 | 6 |
| 7 namespace gin { | 7 namespace gin { |
| 8 | 8 |
| 9 Dictionary::Dictionary(v8::Isolate* isolate) | 9 Dictionary::Dictionary(v8::Isolate* isolate) |
| 10 : isolate_(isolate) { | 10 : isolate_(isolate) { |
| (...skipping 12 matching lines...) Expand all Loading... | |
| 23 Dictionary dictionary(isolate); | 23 Dictionary dictionary(isolate); |
| 24 dictionary.object_ = v8::Object::New(); | 24 dictionary.object_ = v8::Object::New(); |
| 25 return dictionary; | 25 return dictionary; |
| 26 } | 26 } |
| 27 | 27 |
| 28 v8::Handle<v8::Value> Converter<Dictionary>::ToV8(v8::Isolate* isolate, | 28 v8::Handle<v8::Value> Converter<Dictionary>::ToV8(v8::Isolate* isolate, |
| 29 Dictionary val) { | 29 Dictionary val) { |
| 30 return val.object_; | 30 return val.object_; |
| 31 } | 31 } |
| 32 | 32 |
| 33 bool FromV8(v8::Handle<v8::Value> val, Dictionary* out) { | 33 bool Converter<Dictionary>::FromV8(v8::Handle<v8::Value> val, |
| 34 Dictionary* out) { | |
|
abarth-chromium
2013/11/21 02:53:43
This is also an unrelated typo fix.
| |
| 34 if (!val->IsObject()) | 35 if (!val->IsObject()) |
| 35 return false; | 36 return false; |
| 36 *out = Dictionary(out->isolate(), v8::Handle<v8::Object>::Cast(val)); | 37 *out = Dictionary(out->isolate(), v8::Handle<v8::Object>::Cast(val)); |
| 37 return true; | 38 return true; |
| 38 } | 39 } |
| 39 | 40 |
| 40 } // namespace gin | 41 } // namespace gin |
| OLD | NEW |