Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 792013006: [turbofan] Improve JSToBoolean typing. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve JSToBoolean typing. R=svenpanne@chromium.org Committed: https://crrev.com/efd8fd56126a416d7d97a121f8aa918901bb4232 Cr-Commit-Position: refs/heads/master@{#25896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
6 years ago (2014-12-19 05:40:59 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-19 05:41:26 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-19 06:42:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792013006/1
6 years ago (2014-12-19 06:43:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 07:10:25 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-19 07:10:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efd8fd56126a416d7d97a121f8aa918901bb4232
Cr-Commit-Position: refs/heads/master@{#25896}

Powered by Google App Engine
This is Rietveld 408576698