Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 792003002: Remove unused nodes argument to createMarkup() (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
yosin_UTC9, dcheng
CC:
dcheng, blink-reviews, groby+blinkspell_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove unused nodes argument to createMarkup() No client of createMarkup() passed a non-null list of nodes, so simplify by removing it altogether. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M Source/core/clipboard/DataTransfer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/markup.cpp View 6 chunks +6 lines, -8 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
philipj_slow
PTAL
6 years ago (2014-12-10 13:17:47 UTC) #2
dcheng
lgtm
6 years ago (2014-12-10 16:27:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792003002/1
6 years ago (2014-12-10 16:28:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=186866
6 years ago (2014-12-10 18:56:28 UTC) #7
yosin_UTC9
6 years ago (2014-12-11 01:42:14 UTC) #8
Message was sent while issue was closed.
On 2014/12/10 13:17:47, philipj wrote:
> PTAL

Thanks so much! This is listed in my TODO list.
m(_ _)m

Powered by Google App Engine
This is Rietveld 408576698