Set ZERO_AR_DATE=1 when running libtool.

Set ZERO_AR_DATE=1 when running libtool.

This is a reland of https://codereview.chromium.org/699083004/.

See https://code.google.com/p/chromium/issues/detail?id=432483 for the reason of this reland.

BUG=chromium:330262
R=maruel@chromium.org, thakis@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=2020

[Sébastien Marchand, 2014-12-10 22:49:44]

sebmarchand@chromium.org changed reviewers:
+ maruel@chromium.org

[Sébastien Marchand, 2014-12-10 23:13:55]

Patchset #1 (id:1) has been deleted

[Sébastien Marchand, 2014-12-10 23:14:22]

PTAL. Does this approach sgty ?

[M-A Ruel, 2014-12-11 00:41:34]

maruel@chromium.org changed reviewers:
+ thakis@chromium.org

[M-A Ruel, 2014-12-11 00:41:35]

Sounds good, lgtm.

Nico, is the iOS check fine?

https://codereview.chromium.org/791993005/diff/20001/pylib/gyp/mac_tool.py
File pylib/gyp/mac_tool.py (right):

https://codereview.chromium.org/791993005/diff/20001/pylib/gyp/mac_tool.py#ne...
pylib/gyp/mac_tool.py:230: # epoch=0, e.g. 1970-1-1 or 1969-12-31 depending on
daylight saving.
actually, s/daylight saving/timezone/

[Sébastien Marchand, 2014-12-11 18:37:45]

Thanks, waiting for Nico's review.

https://codereview.chromium.org/791993005/diff/20001/pylib/gyp/mac_tool.py
File pylib/gyp/mac_tool.py (right):

https://codereview.chromium.org/791993005/diff/20001/pylib/gyp/mac_tool.py#ne...
pylib/gyp/mac_tool.py:230: # epoch=0, e.g. 1970-1-1 or 1969-12-31 depending on
daylight saving.
On 2014/12/11 00:41:35, M-A Ruel wrote:
> actually, s/daylight saving/timezone/

Done.

[Sébastien Marchand, 2015-01-06 16:31:07]

sebmarchand@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[Sébastien Marchand, 2015-01-06 16:31:13]

Patchset #3 (id:60001) has been deleted

[Sébastien Marchand, 2015-01-06 16:31:41]

I've removed the iOS condition, PTAnL.

[M-A Ruel, 2015-01-06 17:05:45]

lgtm

[Nico, 2015-01-06 17:35:07]

lgtm assuming you have a chromium/ios build set up somewhere to debug problems.
Since this caused problems once and we don't know why, it seems highly likely
it'll cause problems again.

[Sébastien Marchand, 2015-01-07 16:30:42]

On 2015/01/06 at 17:35:07, thakis wrote:
> lgtm assuming you have a chromium/ios build set up somewhere to debug
problems. Since this caused problems once and we don't know why, it seems highly
likely it'll cause problems again.

I've tried this patch on my OS X checkout:
$ ninja -C out/Release-iphoneos
  .... building 29090 targets ...
$ ninja -C out/Release-iphoneos
  ninja: no work to do.

so it seems to be working this time... I'll give a heads up to the bling team
once we roll gyp deps.

[Sébastien Marchand, 2015-01-07 16:46:59]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2015-01-07 16:50:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-07 16:50:26]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Sébastien Marchand, 2015-01-07 16:57:52]

Committed patchset #5 (id:120001) manually as r2020 (presubmit successful).

[scottmg, 2015-01-28 21:04:33]

Hi, I'm getting a non-noop build on Mac related to this.

Building gcapi_lib, it runs

rm -f libgcapi_lib.a && ./gyp-mac-tool filter-libtool libtool  -static -o
libgcapi_lib.a arch/libgcapi_lib.i386.a arch/libgcapi_lib.x86_64.a

but mac_tool.py doesn't touch the output because there's multiple .as when it
looks for len(archives).

Should we instead be parsing for the -o?

[Nico, 2015-01-29 19:29:21]

On 2015/01/28 21:04:33, scottmg wrote:
> Hi, I'm getting a non-noop build on Mac related to this.
> 
> Building gcapi_lib, it runs
> 
> rm -f libgcapi_lib.a && ./gyp-mac-tool filter-libtool libtool  -static -o
> libgcapi_lib.a arch/libgcapi_lib.i386.a arch/libgcapi_lib.x86_64.a
> 
> but mac_tool.py doesn't touch the output because there's multiple .as when it
> looks for len(archives).
> 
> Should we instead be parsing for the -o?

(scott fixed this in https://codereview.chromium.org/879343004/ )