Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 791933006: Add xp optimization for RGB coverage. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add xp optimization for RGB coverage. This is needed since clearColorStages is being changed to ignore color input. For RGB coverage, we want to clear all the color stages (since we know the final output color), but we don't want to ignore the color input since it is needed. In future we will change this so the XP stores the color internally and thus can tell the GP to simiply ignore color. BUG=skia: Committed: https://skia.googlesource.com/skia/+/54160f32865e8bbba18c9a1eb6e46711c8233cdf

Patch Set 1 #

Patch Set 2 : Update naming #

Patch Set 3 : nit #

Patch Set 4 : nits2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -32 lines) Patch
M include/gpu/GrXferProcessor.h View 1 2 3 3 chunks +11 lines, -6 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 5 chunks +27 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
egdaniel
6 years ago (2014-12-15 19:56:06 UTC) #2
egdaniel
updated
6 years ago (2014-12-15 20:23:34 UTC) #3
joshualitt
On 2014/12/15 20:23:34, egdaniel wrote: > updated lgtm
6 years ago (2014-12-15 20:25:23 UTC) #4
bsalomon
lgtm
6 years ago (2014-12-15 20:26:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791933006/60001
6 years ago (2014-12-15 20:27:52 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 20:38:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/54160f32865e8bbba18c9a1eb6e46711c8233cdf

Powered by Google App Engine
This is Rietveld 408576698