Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 791923003: replace COMPILE_ASSERT with static_assert in content/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, asanka, posciak+watch_chromium.org, nasko+codewatch_chromium.org, dgrogan, aandrey+blink_chromium.org, jdduke+watch_chromium.org, vsevik, benjhayden+dwatch_chromium.org, jam, darin-cc_chromium.org, devtools-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, piman+watch_chromium.org, jsbell+idb_chromium.org, mcasas+watch_chromium.org, yurys, cmumford, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in content/ BUG=442514 Committed: https://crrev.com/e29b6889c923e2435baa53943f5b8fcca2eedb38 Cr-Commit-Position: refs/heads/master@{#311250}

Patch Set 1 #

Patch Set 2 : add some larger changes #

Patch Set 3 : minor adjustment #

Total comments: 4

Patch Set 4 : fixups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -493 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_net_log_parameters.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/gamepad/xbox_data_fetcher_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_database.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/power_profiler/power_event.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/websocket_host.cc View 3 chunks +16 lines, -16 lines 0 comments Download
M content/browser/speech/audio_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/chunked_byte_buffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/speech/endpointer/endpointer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognizer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +10 lines, -10 lines 0 comments Download
M content/child/assert_matching_enums.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/browser_font_resource_trusted.cc View 2 chunks +19 lines, -19 lines 0 comments Download
M content/child/file_info_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/quota_dispatcher.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 2 3 2 chunks +93 lines, -93 lines 0 comments Download
M content/common/gpu/media/vaapi_h264_decoder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/input/web_input_event_traits.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/pepper_plugin_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 2 3 1 chunk +46 lines, -46 lines 0 comments Download
M content/renderer/gpu/stream_texture_host_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_track_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/event_conversion.cc View 2 chunks +51 lines, -51 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 3 2 chunks +88 lines, -90 lines 0 comments Download
M content/renderer/pepper/pepper_video_capture_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl_android.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 3 chunks +32 lines, -50 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url2_test.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url_test.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/test/plugin/plugin_geturl_test.cc View 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Mostyn Bramley-Moore
@jam: PTAL
6 years ago (2014-12-23 08:23:07 UTC) #2
Mostyn Bramley-Moore
@cpu: perhaps you can review this?
5 years, 11 months ago (2015-01-09 12:44:00 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm sans the file I mentioned. https://codereview.chromium.org/791923003/diff/40001/content/child/appcache/appcache_frontend_impl.cc File content/child/appcache/appcache_frontend_impl.cc (right): https://codereview.chromium.org/791923003/diff/40001/content/child/appcache/appcache_frontend_impl.cc#newcode131 content/child/appcache/appcache_frontend_impl.cc:131: STATIC_ASSERT_WCM_ENUM(LevelWarning, LOG_WARNING); please ...
5 years, 11 months ago (2015-01-13 02:07:55 UTC) #5
Mostyn Bramley-Moore
https://codereview.chromium.org/791923003/diff/40001/content/child/appcache/appcache_frontend_impl.cc File content/child/appcache/appcache_frontend_impl.cc (right): https://codereview.chromium.org/791923003/diff/40001/content/child/appcache/appcache_frontend_impl.cc#newcode131 content/child/appcache/appcache_frontend_impl.cc:131: STATIC_ASSERT_WCM_ENUM(LevelWarning, LOG_WARNING); On 2015/01/13 02:07:54, cpu wrote: > please ...
5 years, 11 months ago (2015-01-13 08:53:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791923003/60001
5 years, 11 months ago (2015-01-13 08:55:01 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-13 09:59:56 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 10:00:55 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e29b6889c923e2435baa53943f5b8fcca2eedb38
Cr-Commit-Position: refs/heads/master@{#311250}

Powered by Google App Engine
This is Rietveld 408576698