Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 791923002: [Oilpan] Add Silk pages in Oilpan performance page sets (Closed)

Created:
6 years ago by peria
Modified:
6 years ago
Reviewers:
oilpan-reviews, Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add following pages in Oilpan performance page sets - key_silk_cases (disabled) - sync_scroll.key_mobile_sites (enabled on Android) Disabled/Enabled attributes are added referring Smoothness test. BUG=438074 Committed: https://crrev.com/2de852f2c41b366514e487a5a69f67637296b7b1 Cr-Commit-Position: refs/heads/master@{#308058}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M tools/perf/benchmarks/oilpan_gc_times.py View 1 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
peria
PTL.
6 years ago (2014-12-11 04:55:01 UTC) #6
Sami
Thanks for adding these. https://codereview.chromium.org/791923002/diff/60001/tools/perf/benchmarks/oilpan_gc_times.py File tools/perf/benchmarks/oilpan_gc_times.py (right): https://codereview.chromium.org/791923002/diff/60001/tools/perf/benchmarks/oilpan_gc_times.py#newcode41 tools/perf/benchmarks/oilpan_gc_times.py:41: @benchmark.Disabled Why does this need ...
6 years ago (2014-12-11 10:31:33 UTC) #7
peria
https://codereview.chromium.org/791923002/diff/60001/tools/perf/benchmarks/oilpan_gc_times.py File tools/perf/benchmarks/oilpan_gc_times.py (right): https://codereview.chromium.org/791923002/diff/60001/tools/perf/benchmarks/oilpan_gc_times.py#newcode41 tools/perf/benchmarks/oilpan_gc_times.py:41: @benchmark.Disabled On 2014/12/11 10:31:33, Sami (OoO U-2603) wrote: > ...
6 years ago (2014-12-11 13:45:05 UTC) #8
Sami
On 2014/12/11 13:45:05, peria wrote: > https://codereview.chromium.org/791923002/diff/60001/tools/perf/benchmarks/oilpan_gc_times.py > File tools/perf/benchmarks/oilpan_gc_times.py (right): > > https://codereview.chromium.org/791923002/diff/60001/tools/perf/benchmarks/oilpan_gc_times.py#newcode41 > ...
6 years ago (2014-12-11 14:37:36 UTC) #9
Sami
On 2014/12/11 14:37:36, Sami (OoO U-2603) wrote: > On 2014/12/11 13:45:05, peria wrote: > > ...
6 years ago (2014-12-11 14:38:12 UTC) #10
peria
On 2014/12/11 14:37:36, Sami (OoO U-2603) wrote: > On 2014/12/11 13:45:05, peria wrote: > > ...
6 years ago (2014-12-12 04:46:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791923002/80001
6 years ago (2014-12-12 04:46:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:80001)
6 years ago (2014-12-12 06:20:01 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-12 06:21:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2de852f2c41b366514e487a5a69f67637296b7b1
Cr-Commit-Position: refs/heads/master@{#308058}

Powered by Google App Engine
This is Rietveld 408576698