Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 791883003: tuple: leave fields uninitialized in default constructors (Closed)

Created:
6 years ago by mdempsky
Modified:
6 years ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, tdresser
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tuple: leave fields uninitialized in default constructors Using "x()" in TupleLeaf's default constructor causes primitive types (e.g., integers and pointers) to be zero initialized, whereas previously Tuple left them indeterminate. Arguably zero-initializing is better, but the change was inadvertant and results in a measurable code size increase, so this CL reverts it (at least for now). BUG=440806 Committed: https://crrev.com/f2c5add463f5fbb425934ef71390ca848a9df01a Cr-Commit-Position: refs/heads/master@{#308455}

Patch Set 1 #

Patch Set 2 : Fix silly syntax error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/tuple.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mdempsky
6 years ago (2014-12-15 21:36:59 UTC) #2
Nico
lgtm, thanks!
6 years ago (2014-12-15 21:37:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791883003/20001
6 years ago (2014-12-15 21:56:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 23:26:21 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 23:27:18 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2c5add463f5fbb425934ef71390ca848a9df01a
Cr-Commit-Position: refs/heads/master@{#308455}

Powered by Google App Engine
This is Rietveld 408576698