Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 791873002: Cleanup: adopt C++11 range-based-for to simplify the code. (Closed)

Created:
6 years ago by Jun Mukai
Modified:
6 years ago
Reviewers:
oshima
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: adopt C++11 range-based-for to simplify the code. BUG=None R=oshima@chromium.org TEST=build succeed Committed: https://crrev.com/b4fcf221cd9f52f7c21378200c64d4179da747c4 Cr-Commit-Position: refs/heads/master@{#307624}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 3 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Jun Mukai
6 years ago (2014-12-10 01:30:13 UTC) #1
oshima
lgtm https://codereview.chromium.org/791873002/diff/1/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc (right): https://codereview.chromium.org/791873002/diff/1/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc#newcode287 chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:287: for (const auto& display_mode : display_modes) { nit: ...
6 years ago (2014-12-10 01:37:26 UTC) #2
Jun Mukai
https://codereview.chromium.org/791873002/diff/1/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc (right): https://codereview.chromium.org/791873002/diff/1/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc#newcode287 chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:287: for (const auto& display_mode : display_modes) { On 2014/12/10 ...
6 years ago (2014-12-10 01:39:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791873002/20001
6 years ago (2014-12-10 01:42:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-10 02:37:38 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-10 02:38:23 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b4fcf221cd9f52f7c21378200c64d4179da747c4
Cr-Commit-Position: refs/heads/master@{#307624}

Powered by Google App Engine
This is Rietveld 408576698