Add sRGB texture support.

Add sRGB texture support.

Committed: https://skia.googlesource.com/skia/+/fa1e8a7cefd71f7b75f0b85f8eefe111814dd86f

[jvanverth1, 2014-12-18 21:28:35]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com

[jvanverth1, 2014-12-18 21:28:36]

As far as I can tell this is correct. The spec doesn't seem to mention how
multisampled textures are handled. EXT_framebuffer_sRGB mentions that it depends
on the implementation, but they would expect that it would be converted to
linear before sampling.

There doesn't appear to be a way to enable/disable sRGB other than using the
format.

[bsalomon, 2014-12-19 14:21:54]

On 2014/12/18 21:28:36, jvanverth1 wrote:
> As far as I can tell this is correct. The spec doesn't seem to mention how
> multisampled textures are handled. EXT_framebuffer_sRGB mentions that it
depends
> on the implementation, but they would expect that it would be converted to
> linear before sampling.
> 
> There doesn't appear to be a way to enable/disable sRGB other than using the
> format.

Is there some GL code that goes along with this?

[bsalomon, 2014-12-19 15:12:55]

On 2014/12/18 21:28:36, jvanverth1 wrote:
> As far as I can tell this is correct. The spec doesn't seem to mention how
> multisampled textures are handled. EXT_framebuffer_sRGB mentions that it
depends
> on the implementation, but they would expect that it would be converted to
> linear before sampling.
> 
> There doesn't appear to be a way to enable/disable sRGB other than using the
> format.

https://www.opengl.org/registry/specs/EXT/texture_sRGB_decode.txt

[jvanverth1, 2014-12-19 15:13:59]

On 2014/12/19 14:21:54, bsalomon wrote:
> On 2014/12/18 21:28:36, jvanverth1 wrote:
> > As far as I can tell this is correct. The spec doesn't seem to mention how
> > multisampled textures are handled. EXT_framebuffer_sRGB mentions that it
> depends
> > on the implementation, but they would expect that it would be converted to
> > linear before sampling.
> > 
> > There doesn't appear to be a way to enable/disable sRGB other than using the
> > format.
> 
> Is there some GL code that goes along with this?

Er.... yes. Yes, there is.

[bsalomon, 2014-12-19 15:15:27]

On 2014/12/19 15:12:55, bsalomon wrote:
> On 2014/12/18 21:28:36, jvanverth1 wrote:
> > As far as I can tell this is correct. The spec doesn't seem to mention how
> > multisampled textures are handled. EXT_framebuffer_sRGB mentions that it
> depends
> > on the implementation, but they would expect that it would be converted to
> > linear before sampling.
> > 
> > There doesn't appear to be a way to enable/disable sRGB other than using the
> > format.
> 
> https://www.opengl.org/registry/specs/EXT/texture_sRGB_decode.txt

That one allows control of lin->srgb during sampling.

https://www.opengl.org/registry/specs/EXT/framebuffer_sRGB.txt
has gl[En|Dis]able(FRAMEBUFFER_SRGB_EXT) to control writes to the FB

[jvanverth1, 2014-12-19 20:35:18]

jvanverth@google.com changed reviewers:
+ reed@android.com

[jvanverth1, 2014-12-19 20:35:19]

(Adding reed@)

Here's another pass at it. I'm not 100% sure about the changes to
SkPixelRef::deepCopy, but it appears that we need to get the SkColorProfileType
from the SkBitmap, in order to pass it down to copy_to_new_texture_pixelref().

[reed1, 2014-12-19 21:32:55]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2014-12-19 21:32:56]

https://codereview.chromium.org/791823003/diff/40001/include/core/SkPixelRef.h
File include/core/SkPixelRef.h (right):

https://codereview.chromium.org/791823003/diff/40001/include/core/SkPixelRef....
include/core/SkPixelRef.h:263: virtual SkPixelRef* deepCopy(SkColorType,
SkColorProfileType, const SkIRect* /*subset*/) {
are there any subclasses of this in Blink or Chrome?

[jvanverth1, 2014-12-22 15:05:29]

On 2014/12/19 21:32:56, reed1 wrote:
> https://codereview.chromium.org/791823003/diff/40001/include/core/SkPixelRef.h
> File include/core/SkPixelRef.h (right):
> 
>
https://codereview.chromium.org/791823003/diff/40001/include/core/SkPixelRef....
> include/core/SkPixelRef.h:263: virtual SkPixelRef* deepCopy(SkColorType,
> SkColorProfileType, const SkIRect* /*subset*/) {
> are there any subclasses of this in Blink or Chrome?

I don't see any in the Chrome code search. There's a utility wrapper for
SkPixelRef which doesn't use deepCopy().

[reed1, 2014-12-22 15:14:28]

lgtm

[bsalomon, 2014-12-22 15:52:35]

lgtm

[jvanverth1, 2014-12-22 16:22:02]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-12-22 16:22:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/791823003/40001

[commit-bot: I haz the power, 2014-12-22 16:31:53]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/fa1e8a7cefd71f7b75f0b85f8eefe111814dd86f