Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 791813007: Revert of Temporarily restore make dependencies (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Revert of Temporarily restore make dependencies (patchset #1 id:1 of https://codereview.chromium.org/733203008/) Reason for revert: make dependencies is stale now, and everybody should have switched over Original issue's description: > Temporarily restore make dependencies > > We will remove dependencies in about a week again. > > BUG=none > R=machenbach@chromium.org > LOG=y TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/9d25205b29521e1c6b1842bf8b1d79a824901d4c Cr-Commit-Position: refs/heads/master@{#26134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M Makefile View 2 chunks +2 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Temporarily restore make dependencies
5 years, 11 months ago (2015-01-19 13:20:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791813007/1
5 years, 11 months ago (2015-01-19 13:20:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-19 13:21:12 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 13:21:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d25205b29521e1c6b1842bf8b1d79a824901d4c
Cr-Commit-Position: refs/heads/master@{#26134}

Powered by Google App Engine
This is Rietveld 408576698