Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 791743004: events: Generalize IsTouchscreenInternal to any device type (Closed)

Created:
6 years ago by spang
Modified:
6 years ago
Reviewers:
rsadam, sadrul
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

events: Generalize IsTouchscreenInternal to any device type This logic can also be used for keyboards, mice, touchpads, and tablets. TEST=chrome on link_freon & rush_ryu BUG=437539 Committed: https://crrev.com/c61e0f5a5ea617ac0c94c7be79f398ff8fa22f95 Cr-Commit-Position: refs/heads/master@{#308082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M ui/events/devices/device_util_linux.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/events/devices/device_util_linux.cc View 2 chunks +28 lines, -11 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
spang
6 years ago (2014-12-11 01:29:08 UTC) #2
sadrul
lgtm
6 years ago (2014-12-11 15:32:54 UTC) #3
rsadam
lgtm
6 years ago (2014-12-11 16:35:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791743004/1
6 years ago (2014-12-12 06:31:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/42095) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29949) linux_chromium_asan_rel ...
6 years ago (2014-12-12 06:35:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791743004/1
6 years ago (2014-12-12 09:13:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 14:44:24 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-12 14:45:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c61e0f5a5ea617ac0c94c7be79f398ff8fa22f95
Cr-Commit-Position: refs/heads/master@{#308082}

Powered by Google App Engine
This is Rietveld 408576698