src/effects/SkLightingImageFilter.cpp - Issue 791743003: Remove GP from drawstate, revision of invariant output for GP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 791743003: Remove GP from drawstate, revision of invariant output for GP (Closed) Base URL: https://skia.googlesource.com/skia.git@color-to-gp

Patch Set: feedback inc Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index adac45bdc9df826959c2e216013561ee00227f46..e53cb02569d4e83334df812a3679d2503c2a3e49 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -349,7 +349,7 @@ protected:

virtual void onComputeInvariantOutput(GrInvariantOutput* inout) const SK_OVERRIDE {

// lighting shaders are complicated. We just throw up our hands.

- inout->mulByUnknownColor();

+ inout->mulByUnknownFourComponents();

}

private:

« include/gpu/GrInvariantOutput.h ('K') | « src/effects/SkBlurMaskFilter.cpp ('k') | src/effects/gradients/SkGradientShader.cpp » ('j') | src/gpu/GrAARectRenderer.cpp » ('J')