split out chromium_mojo recipe changes from chromium_mojo master cl

Split the chromium_gn.py in two for chromium.mojo.

We will be setting up a new chromium.mojo master and new bots
dedicated to running tests for the Mojo services that live in
the Chromium repo. We do not want to re-use the normal GN bots,
in order to minimize confusion.

This CL creates a new 'chromium_mojo.py' recipe and refactors much
of the code shared by the chromium_mojo and chromium_gn recipes
into routines that move into the chromium recipe_module.

R=jamesr@chromium.org, iannucci@chromium.org
BUG=439281
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293388

[Dirk Pranke, 2014-12-10 22:36:32]

Please take a look?

[jamesr, 2014-12-10 22:41:54]

chromium_mojo.py and the golden files lgtm.  I don't really feel qualified to
review the rest, but it seems sane as far as I can tell (which isn't very).

[Dirk Pranke, 2014-12-12 21:23:52]

Robbie, ping?

[iannucci, 2014-12-12 23:45:19]

lgtm

https://codereview.chromium.org/791733005/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/791733005/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/api.py:116: def configure_bot(self,
builders_dict, additional_configs=None):
assuming that builders_dict is ~{mastername -> {buildername -> stuff}}?

https://codereview.chromium.org/791733005/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/test_api.py (right):

https://codereview.chromium.org/791733005/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/test_api.py:17: # tests. Is this really
the right place?
this is an OK place... the test api can contain whatever you need to make
writing GenTests for a given recipe module better.

[iannucci, 2014-12-12 23:45:46]

https://codereview.chromium.org/791733005/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/791733005/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/api.py:116: def configure_bot(self,
builders_dict, additional_configs=None):
On 2014/12/12 23:45:19, iannucci wrote:
> assuming that builders_dict is ~{mastername -> {buildername -> stuff}}?

Actually.. that should probably be in the docstring somewhere

[Dirk Pranke, 2014-12-12 23:59:48]

https://codereview.chromium.org/791733005/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/791733005/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/api.py:116: def configure_bot(self,
builders_dict, additional_configs=None):
On 2014/12/12 23:45:46, iannucci wrote:
> On 2014/12/12 23:45:19, iannucci wrote:
> > assuming that builders_dict is ~{mastername -> {buildername -> stuff}}?
> 
> Actually.. that should probably be in the docstring somewhere

Fixed.

[Dirk Pranke, 2014-12-12 23:59:53]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-12-13 00:00:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/791733005/40001

[commit-bot: I haz the power, 2014-12-13 00:03:15]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293388