Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 79173002: Remove unnamed namespace usage from 'gm'. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove unnamed namespace usage from 'gm'. Skia prefers static over unnamed namespaces. BUG=None TEST=None R=bsalomon@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=12326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -49 lines) Patch
M gm/imagefiltersgraph.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M gm/optimizations.cpp View 11 chunks +37 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
trivial cleanup...
7 years, 1 month ago (2013-11-20 19:19:47 UTC) #1
robertphillips
lgtm
7 years, 1 month ago (2013-11-20 19:30:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/79173002/1
7 years, 1 month ago (2013-11-20 19:36:18 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 21:32:22 UTC) #4
Message was sent while issue was closed.
Change committed as 12326

Powered by Google App Engine
This is Rietveld 408576698