Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Issue 791723002: Change build-ctags.sh output file name from ".tags" to "tags" (Closed)

Created:
6 years ago by servolk
Modified:
6 years ago
Reviewers:
jww, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change build-ctags.sh output file name from ".tags" to "tags" Two reasons for this change: 1. Default value of the tags option in Vim (that tells it where to load tags from) is: "tags=./tags,./TAGS,tags,TAGS" So now Vim should be able to pick up tags with default settings when current dir is chromium/src 2. src/.gitignore already has "tags" in it, but not ".tags" which, I think, indicates that people expect the tags file name to not have a leading dot BUG=none Committed: https://crrev.com/fbc0ebe4967befb4643a3e286b0f8f376322dc07 Cr-Commit-Position: refs/heads/master@{#307539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/build-ctags.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
servolk
6 years ago (2014-12-09 19:15:36 UTC) #3
Nico
lgtm if jww likes it
6 years ago (2014-12-09 19:17:13 UTC) #4
jww
Sure, lgtm
6 years ago (2014-12-09 19:46:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791723002/1
6 years ago (2014-12-09 19:48:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 20:35:57 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-09 20:36:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbc0ebe4967befb4643a3e286b0f8f376322dc07
Cr-Commit-Position: refs/heads/master@{#307539}

Powered by Google App Engine
This is Rietveld 408576698