Allocate memory for external snapshot paths in d8

src/d8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 // Defined when linking against shared lib on Windows.
 #if defined(USING_V8_SHARED) && !defined(V8_SHARED)
 #define V8_SHARED
 #endif
 
@@ skipping 1537 matching lines @@
 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
 class StartupDataHandler {
  public:
   StartupDataHandler(const char* exec_path, const char* natives_blob,
                      const char* snapshot_blob) {
     // If we have (at least one) explicitly given blob, use those.
     // If not, use the default blob locations next to the d8 binary.
     if (natives_blob || snapshot_blob) {
       LoadFromFiles(natives_blob, snapshot_blob);
     } else {
-      char natives[100], snapshot[100];
-      LoadFromFiles(
-          RelativePath(natives, exec_path, "natives_blob.bin", sizeof(natives)),
-          RelativePath(snapshot, exec_path, "snapshot_blob.bin",
-                       sizeof(snapshot)));
+      char* natives;
+      char* snapshot;
+      LoadFromFiles(RelativePath(&natives, exec_path, "natives_blob.bin"),
+                    RelativePath(&snapshot, exec_path, "snapshot_blob.bin"));
+
+      free(natives);
+      free(snapshot);
     }
   }
 
   ~StartupDataHandler() {
     delete[] natives_.data;
     delete[] snapshot_.data;
   }
 
  private:
-  static char* RelativePath(char* buffer, const char* exec_path,
-                            const char* name, int buffer_length) {
+  static char* RelativePath(char** buffer, const char* exec_path,
+                            const char* name) {
     DCHECK(exec_path);
     const char* last_slash = strrchr(exec_path, '/');
     if (last_slash) {
       int after_slash = last_slash - exec_path + 1;
-      DCHECK(buffer_length > after_slash);
-      strncpy(buffer, exec_path, after_slash);
-      buffer[after_slash] = '\0';
-      return strncat(buffer, name, buffer_length);
+      int name_length = strlen(name);
+      *buffer =
+          reinterpret_cast<char*>(calloc(after_slash + name_length + 1, 1));
+      strncpy(*buffer, exec_path, after_slash);
+      strncat(*buffer, name, name_length);
     } else {
-      return strncpy(buffer, name, buffer_length);
+      *buffer = strdup(name);
     }
+    return *buffer;
   }
 
   void LoadFromFiles(const char* natives_blob, const char* snapshot_blob) {
     Load(natives_blob, &natives_, v8::V8::SetNativesDataBlob);
     Load(snapshot_blob, &snapshot_, v8::V8::SetSnapshotDataBlob);
   }
 
   void Load(const char* blob_file,
             v8::StartupData* startup_data,
             void (*setter_fn)(v8::StartupData*)) {
@@ skipping 151 matching lines @@
 }
 
 }  // namespace v8
 
 
 #ifndef GOOGLE3
 int main(int argc, char* argv[]) {
   return v8::Shell::Main(argc, argv);
 }
 #endif