Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 791693005: PPC aftermath: Fix regress-crbug-178790. (Closed)

Created:
5 years, 11 months ago by Sven Panne
Modified:
5 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC aftermath: Fix regress-crbug-178790. The test fails on XP only, so let's tentatively raise the stack limit more. We probably need to investigate what a tighter limit might be and (more importantly) what the underlying reason for the failure is. Hopefully 1800kB is enough, we can't test this via try jobs, because we don't have XP try bots. :-/ R=machenbach@chromium.org Committed: https://crrev.com/54570cfa74f99dc3628a193c4161de7b09183fe7 Cr-Commit-Position: refs/heads/master@{#26092}

Patch Set 1 #

Patch Set 2 : Experiment: Remove everything but r1. #

Patch Set 3 : Raise stack size to 1800kB. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/regress/regress-crbug-178790.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
lgtm
5 years, 11 months ago (2015-01-16 09:45:08 UTC) #2
Sven Panne
Committed patchset #3 (id:40001) manually as 54570cfa74f99dc3628a193c4161de7b09183fe7 (presubmit successful).
5 years, 11 months ago (2015-01-16 09:45:37 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 09:45:41 UTC) #4
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/54570cfa74f99dc3628a193c4161de7b09183fe7
Cr-Commit-Position: refs/heads/master@{#26092}

Powered by Google App Engine
This is Rietveld 408576698