Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 791633010: StyleSheetContents doesn't need a set of clients. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
eseidel, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

StyleSheetContents doesn't need a set of clients. The clients were only used to call clearResolver(), but all clients in Sky are from the same document, so we can just store the document instead. We can also use the lifetime of the StyleSheetContents object to manage the cache in the StyleEngine instead of the list of clients. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f4575b1ecf1cf48e2f7434ba5ae1cf351b344518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -56 lines) Patch
M sky/engine/core/css/CSSStyleSheet.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.h View 2 chunks +4 lines, -8 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 4 chunks +5 lines, -37 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-17 00:14:16 UTC) #2
eseidel
lgtm
6 years ago (2014-12-17 00:20:19 UTC) #3
esprehn
6 years ago (2014-12-17 00:22:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f4575b1ecf1cf48e2f7434ba5ae1cf351b344518 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698