chrome/browser/ui/content_settings/content_setting_bubble_model.cc - Issue 791633003: Fix a crash on closing tab while the plugin settings bubble is visible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

Issue 791633003: Fix a crash on closing tab while the plugin settings bubble is visible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/content_settings/content_setting_bubble_model.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

index 1e3433a5ca01d000f1854756f0ec8aa07225a17a..72615b9a244fcc16b3ccf31f2a1f73f963b85a18 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc

@@ -497,7 +497,8 @@ ContentSettingPluginBubbleModel::~ContentSettingPluginBubbleModel() {

void ContentSettingPluginBubbleModel::OnCustomLinkClicked() {

content::RecordAction(UserMetricsAction("ClickToPlay_LoadAll_Bubble"));

- DCHECK(web_contents());

+ if (!web_contents())

markusheintz_ 2014/12/12 09:43:09 Please add a comment above this line that explains

+ return;

#if defined(ENABLE_PLUGINS)

// TODO(bauerb): We should send the identifiers of blocked plug-ins here.

ChromePluginServiceFilter::GetInstance()->AuthorizeAllPlugins(

« no previous file with comments | « no previous file | no next file » | no next file with comments »