Issue 791613002: Oilpan: use Member<> for FilterEffect's filter reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 791613002: Oilpan: use Member<> for FilterEffect's filter reference. (Closed)

Created:
6 years ago by sof

Modified:
6 years ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: use Member<> for FilterEffect's filter reference. Both FilterEffect and SkiaImageFilterBuilder keep assumed strong references to GCed objects, but without tracing them. Add the required Member<> to these references and trace them (when explicitly needed.) R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186767

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -5 lines)			Patch
M	Source/platform/graphics/filters/FilterEffect.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/graphics/filters/FilterEffect.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/graphics/filters/SkiaImageFilterBuilder.h	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791613002/1

6 years ago (2014-12-09 09:00:37 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-09 10:04:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186767

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages