WIP context-allocation for “this” in arrow functions

src/ast-numbering.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/ast.h"
 #include "src/ast-numbering.h"
 #include "src/compiler.h"
 #include "src/scopes.h"
@@ skipping 541 matching lines @@
   if (scope->HasIllegalRedeclaration()) {
     scope->VisitIllegalRedeclaration(this);
     DisableCrankshaft(kFunctionWithIllegalRedeclaration);
     return Finish(node);
   }
   if (scope->calls_eval()) DisableCrankshaft(kFunctionCallsEval);
   if (scope->arguments() != NULL && !scope->arguments()->IsStackAllocated()) {
     DisableCrankshaft(kContextAllocatedArguments);
   }
 
+  // TODO(aperez): Add support in Crankshaft for arrow functions.

[wingo, 2015/01/15 10:09:05]

Let's file a bug for the tasks needed in Crankshaft, and mention the bug here.

[aperez, 2015/01/15 16:58:03]

Done.

+  if (scope->is_arrow_scope() && scope->uses_this()) {
+    DisableCrankshaft(kCapturedThis);
+  }
+  if (scope->is_function_scope() && scope->inner_uses_this()) {
+    DisableCrankshaft(kCapturedThis);
+  }
+
   VisitDeclarations(scope->declarations());
   if (scope->is_function_scope() && scope->function() != NULL) {
     // Visit the name of the named function expression.
     Visit(scope->function());
   }
   VisitStatements(node->body());
 
   return Finish(node);
 }
 
 
 bool AstNumbering::Renumber(FunctionLiteral* function, Zone* zone) {
   AstNumberingVisitor visitor(zone);
   return visitor.Renumber(function);
 }
 }
 }  // namespace v8::internal