Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 7916: Port bunch of files in net/ (Closed)

Created:
12 years, 2 months ago by please use my chromium address
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Port bunch of files in net/ BUG=2623

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M net/base/dns_resolution_observer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/net_lib.scons View 1 chunk +0 lines, -8 lines 0 comments Download
M net/net_unittests.scons View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_filter.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
please use my chromium address
12 years, 2 months ago (2008-10-23 14:25:53 UTC) #1
dank
LGTM, with comments. http://codereview.chromium.org/7916/diff/1/2 File net/http/http_network_transaction.cc (right): http://codereview.chromium.org/7916/diff/1/2#newcode424 Line 424: if ((reused_socket_ = (connection_.socket() != ...
12 years, 2 months ago (2008-10-23 15:56:36 UTC) #2
please use my chromium address
http://codereview.chromium.org/7916/diff/1/2 File net/http/http_network_transaction.cc (right): http://codereview.chromium.org/7916/diff/1/2#newcode424 Line 424: if ((reused_socket_ = (connection_.socket() != NULL))) { On ...
12 years, 2 months ago (2008-10-23 16:07:40 UTC) #3
Mark Mentovai
LGTM
12 years, 2 months ago (2008-10-23 16:18:44 UTC) #4
Mark Mentovai
12 years, 2 months ago (2008-10-23 21:42:30 UTC) #5
Checked in, r3867

Powered by Google App Engine
This is Rietveld 408576698