Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 791583002: Oilpan: remove redundant WILL_BE_EAGERLY_TRACED() declarations. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rwlbuis, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Oilpan: remove redundant WILL_BE_EAGERLY_TRACED() declarations. With eager tracing of GC objects now being the default, remove the WILL_BE_EAGERLY_TRACED() trait declarations added by r186410 for Web Animations related objects. Now redundant. Not a straight revert of r186410, as it also tidied up some tracing details for InterpolableValue subclasses; want to keep those. R=kouhei,haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -43 lines) Patch
M Source/core/animation/ActiveAnimations.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationNode.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/animation/AnimationStack.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/InterpolableValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/Interpolation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/InterpolationEffect.h View 2 chunks +5 lines, -8 lines 0 comments Download
M Source/core/animation/Keyframe.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/SampledEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSKeyframeRule.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/RuleSet.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/StyleRule.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look.
6 years ago (2014-12-09 07:39:52 UTC) #2
kouhei (in TOK)
lgtm
6 years ago (2014-12-09 07:59:13 UTC) #4
haraken
LGTM
6 years ago (2014-12-09 08:16:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791583002/1
6 years ago (2014-12-09 12:07:10 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-09 12:46:51 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186771

Powered by Google App Engine
This is Rietveld 408576698