content/common/gpu/media/video_decode_accelerator_unittest.cc - Issue 791573002: fix video_decode_accelerator_unittest issue when decode speed is slow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/video_decode_accelerator_unittest.cc

Issue 791573002: fix video_decode_accelerator_unittest issue when decode speed is slow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issue in video unit test that Flush/Reset is not reached when decode speed is slow Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/media/video_decode_accelerator_unittest.cc

diff --git a/content/common/gpu/media/video_decode_accelerator_unittest.cc b/content/common/gpu/media/video_decode_accelerator_unittest.cc

index 8b89d049b9339115a642f008e93f3796be83eb12..c4d02dffa44e3e259658c2ccbb0b0d58d9e620c6 100644

--- a/content/common/gpu/media/video_decode_accelerator_unittest.cc

+++ b/content/common/gpu/media/video_decode_accelerator_unittest.cc

@@ -546,7 +546,12 @@ void GLRenderingVDAClient::NotifyEndOfBitstreamBuffer(

// VaapiVideoDecodeAccelerator::FinishReset()).

++num_done_bitstream_buffers_;

--outstanding_decodes_;

- if (decode_calls_per_second_ == 0)

+ if (decode_calls_per_second_ == 0

+ // when decode speed is slow, a BitstreamBuffer is released after the

Alexei Svitkine (slow) 2014/12/09 14:27:35 Nit: Comments should be full sentences.

+ // EOS-DecodeNextFragment(),

+ // trigger DecodeNextFragment again (it will flush decode)

+ || (encoded_data_next_pos_to_decode_ == encoded_data_.size()

Alexei Svitkine (slow) 2014/12/09 14:27:36 Nit: When wrapping, operators (e.g. || and &&) sho

+ && outstanding_decodes_ == 0))

DecodeNextFragment();

}

« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »