fix video_decode_accelerator_unittest issue when decode speed is slow

content/common/gpu/media/video_decode_accelerator_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The bulk of this file is support code; sorry about that.  Here's an overview
 // to hopefully help readers of this code:
 // - RenderingHelper is charged with interacting with X11/{EGL/GLES2,GLX/GL} or
 //   Win/EGL.
 // - ClientState is an enum for the state of the decode client used by the test.
 // - ClientStateNotification is a barrier abstraction that allows the test code
@@ skipping 528 matching lines @@
 }
 
 void GLRenderingVDAClient::NotifyEndOfBitstreamBuffer(
     int32 bitstream_buffer_id) {
   // TODO(fischman): this test currently relies on this notification to make
   // forward progress during a Reset().  But the VDA::Reset() API doesn't
   // guarantee this, so stop relying on it (and remove the notifications from
   // VaapiVideoDecodeAccelerator::FinishReset()).
   ++num_done_bitstream_buffers_;
   --outstanding_decodes_;
-  if (decode_calls_per_second_ == 0)
+  if (decode_calls_per_second_ == 0 ||
+      // when decoding speed is slow, some BitstreamBuffer may be released

[Owen Lin, 2015/01/08 06:26:08]

s/when/When/
s/speed//

+      // after DecodeNextFragment process to the end; which means
+      // outstanding_decodes_ is not zero at that time.

[Owen Lin, 2015/01/08 06:26:08]

|outstanding_decodes_|

+      // we need trigger DecodeNextFragment another time to flush decode.

[Owen Lin, 2015/01/08 06:26:08]

In order to flush the decoder, we need trigger DecodeNextFragment when the last
BitstreamBuffer released.

+      (encoded_data_next_pos_to_decode_ == encoded_data_.size() &&
+       outstanding_decodes_ == 0))
     DecodeNextFragment();

[Owen Lin, 2015/01/08 06:26:08]

How could you prevent to flush the decoder twice ?

I am thinking maybe we should move the flush decoder part from
DecodeNextFragment to NotifyEndOfBitstreamBuffer. How do you think?

 }
 
 void GLRenderingVDAClient::NotifyFlushDone() {
   if (decoder_deleted())
     return;
 
   SetState(CS_FLUSHED);
   --remaining_play_throughs_;
   DCHECK_GE(remaining_play_throughs_, 0);
   if (decoder_deleted())
@@ skipping 878 matching lines @@
     if (it->first == "v" || it->first == "vmodule")
       continue;
     LOG(FATAL) << "Unexpected switch: " << it->first << ":" << it->second;
   }
 
   base::ShadowingAtExitManager at_exit_manager;
   content::RenderingHelper::InitializeOneOff();
 
   return RUN_ALL_TESTS();
 }