Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Side by Side Diff: Source/core/html/HTMLOptionElement.h

Issue 791533004: Don't updateRenderTree in the middle of a DOM insertion. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) 2010 Google Inc. All rights reserved. 6 * Copyright (C) 2010 Google Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 bool isDisplayNone() const; 71 bool isDisplayNone() const;
72 private: 72 private:
73 explicit HTMLOptionElement(Document&); 73 explicit HTMLOptionElement(Document&);
74 virtual ~HTMLOptionElement(); 74 virtual ~HTMLOptionElement();
75 75
76 virtual bool rendererIsFocusable() const override { return true; } 76 virtual bool rendererIsFocusable() const override { return true; }
77 virtual void attach(const AttachContext& = AttachContext()) override; 77 virtual void attach(const AttachContext& = AttachContext()) override;
78 virtual void detach(const AttachContext& = AttachContext()) override; 78 virtual void detach(const AttachContext& = AttachContext()) override;
79 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide; 79 virtual void parseAttribute(const QualifiedName&, const AtomicString&) overr ide;
80 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override; 80 virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
81 virtual void didNotifySubtreeInsertionsToDocument() override;
81 virtual void removedFrom(ContainerNode*) override; 82 virtual void removedFrom(ContainerNode*) override;
82 virtual void accessKeyAction(bool) override; 83 virtual void accessKeyAction(bool) override;
83 virtual void childrenChanged(const ChildrenChange&) override; 84 virtual void childrenChanged(const ChildrenChange&) override;
84 85
85 // <option> never has a renderer so we manually manage a cached style. 86 // <option> never has a renderer so we manually manage a cached style.
86 void updateNonRenderStyle(); 87 void updateNonRenderStyle();
87 virtual RenderStyle* nonRendererStyle() const override; 88 virtual RenderStyle* nonRendererStyle() const override;
88 virtual PassRefPtr<RenderStyle> customStyleForRenderer() override; 89 virtual PassRefPtr<RenderStyle> customStyleForRenderer() override;
89 virtual void didRecalcStyle(StyleRecalcChange) override; 90 virtual void didRecalcStyle(StyleRecalcChange) override;
90 virtual void didAddUserAgentShadowRoot(ShadowRoot&) override; 91 virtual void didAddUserAgentShadowRoot(ShadowRoot&) override;
91 92
92 String collectOptionInnerText() const; 93 String collectOptionInnerText() const;
93 94
94 void updateLabel(); 95 void updateLabel();
95 96
96 bool m_disabled; 97 bool m_disabled;
97 bool m_isSelected; 98 bool m_isSelected;
98 RefPtr<RenderStyle> m_style; 99 RefPtr<RenderStyle> m_style;
99 }; 100 };
100 101
101 } // namespace blink 102 } // namespace blink
102 103
103 #endif // HTMLOptionElement_h 104 #endif // HTMLOptionElement_h
OLDNEW
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/html/HTMLOptionElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698