Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 791523002: Expose fetch function to Window and WorkerGlobalScope. (Closed)

Created:
6 years ago by yhirano
Modified:
6 years ago
Reviewers:
tkent, kouhei (in TOK), horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, kinuko+worker_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Expose fetch function to Window and WorkerGlobalScope. Expose "fetch" function to Window and WorkerGlobalScope under "GlobalFetch" runtime enabled flag. This CL doesn't expose other interfaces such as Request, Response and so on. BUG=436770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186770

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -31 lines) Patch
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/FetchManager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/FetchManager.cpp View 1 2 3 2 chunks +12 lines, -3 lines 0 comments Download
A Source/modules/serviceworkers/GlobalFetch.h View 1 chunk +27 lines, -0 lines 0 comments Download
A Source/modules/serviceworkers/GlobalFetch.cpp View 1 2 3 1 chunk +96 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 4 chunks +2 lines, -19 lines 0 comments Download
A + Source/modules/serviceworkers/WindowFetch.idl View 1 chunk +3 lines, -3 lines 0 comments Download
A Source/modules/serviceworkers/WorkerFetch.idl View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
yhirano
PTAL horo@: modules kouhei@: core
6 years ago (2014-12-09 06:29:34 UTC) #2
horo
https://codereview.chromium.org/791523002/diff/40001/Source/modules/serviceworkers/FetchManager.cpp File Source/modules/serviceworkers/FetchManager.cpp (right): https://codereview.chromium.org/791523002/diff/40001/Source/modules/serviceworkers/FetchManager.cpp#newcode358 Source/modules/serviceworkers/FetchManager.cpp:358: stop(); please check m_isStopped. if (!m_isStopped) stop(); https://codereview.chromium.org/791523002/diff/40001/Source/modules/serviceworkers/FetchManager.cpp#newcode373 Source/modules/serviceworkers/FetchManager.cpp:373: ...
6 years ago (2014-12-09 08:04:09 UTC) #3
yhirano
https://codereview.chromium.org/791523002/diff/40001/Source/modules/serviceworkers/FetchManager.cpp File Source/modules/serviceworkers/FetchManager.cpp (right): https://codereview.chromium.org/791523002/diff/40001/Source/modules/serviceworkers/FetchManager.cpp#newcode358 Source/modules/serviceworkers/FetchManager.cpp:358: stop(); On 2014/12/09 08:04:09, horo wrote: > please check ...
6 years ago (2014-12-09 08:10:58 UTC) #4
kouhei (in TOK)
core lgtm
6 years ago (2014-12-09 08:14:56 UTC) #5
horo
lgtm
6 years ago (2014-12-09 08:20:35 UTC) #6
yhirano
+tkent for platform/RuntimeEnabledFeatures.in
6 years ago (2014-12-09 08:21:42 UTC) #8
tkent
Source/platform lgtm
6 years ago (2014-12-09 08:46:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791523002/60001
6 years ago (2014-12-09 08:47:31 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-09 10:53:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186770

Powered by Google App Engine
This is Rietveld 408576698