Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issue 791503002: Base: Add Process::WaitForExit and WaitForExitWithTimeout. (Closed)

Created:
6 years ago by rvargas (doing something else)
Modified:
6 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Base: Add Process::WaitForExit and WaitForExitWithTimeout. The new methods are meant to replace similar functions from kill.h BUG=417532 Committed: https://crrev.com/126fd5821f27793535bd80642c6e87c56b2634a1 Cr-Commit-Position: refs/heads/master@{#308009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M base/process/process.h View 2 chunks +8 lines, -0 lines 0 comments Download
M base/process/process_posix.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M base/process/process_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M base/process/process_win.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rvargas (doing something else)
6 years ago (2014-12-09 03:18:28 UTC) #2
rvargas (doing something else)
On 2014/12/09 03:18:28, rvargas wrote: ping
6 years ago (2014-12-10 21:56:47 UTC) #3
cpu_(ooo_6.6-7.5)
that test might end up being flaky but I don't have great suggestions. I guess ...
6 years ago (2014-12-11 21:11:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/791503002/1
6 years ago (2014-12-11 23:08:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 00:25:22 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 00:26:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/126fd5821f27793535bd80642c6e87c56b2634a1
Cr-Commit-Position: refs/heads/master@{#308009}

Powered by Google App Engine
This is Rietveld 408576698