Add wrappers around getxattr() and setxattr().

util/mac/xattr_test.cc

+// Copyright 2014 The Crashpad Authors. All rights reserved.

[Mark Mentovai, 2014/12/19 23:16:32]

CL description: TEST=

[Robert Sesek, 2014/12/30 17:02:21]

Done.

+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "util/mac/xattr.h"
+
+#include <fcntl.h>
+#include <sys/stat.h>
+#include <unistd.h>
+
+#include <limits>
+
+#include "base/files/scoped_file.h"
+#include "base/strings/stringprintf.h"
+#include "gtest/gtest.h"
+
+namespace crashpad {
+namespace test {
+namespace {
+
+class Xattr : public testing::Test {
+ public:
+  void SetUp() override {

[Mark Mentovai, 2014/12/19 23:16:32]

// testing::Test: to tell what it’s overriding (although in this case, it’s
obvious, since there’s only one base.)

[Robert Sesek, 2014/12/30 17:02:21]

Done.

+    path_ = base::FilePath(
+        base::StringPrintf("/tmp/com.google.crashpad.test.xattr.%p", this));

[Mark Mentovai, 2014/12/19 23:16:32]

org.googlecode.crashpad

[Robert Sesek, 2014/12/30 17:02:21]

Done.

+    base::ScopedFD tmp(open(path_.value().c_str(), O_CREAT | O_TRUNC, S_IRWXU));

[Mark Mentovai, 2014/12/19 23:16:32]

You don’t want the x-bit. S_IRUSR | S_IWUSR. I’d probably just write 0644 and
let the umask sort it out.

You must use O_EXCL.

You must use HANDLE_EINTR and #include the proper header.

You should leave behind a TODO or a bug reference saying that this really wants
ScopedTempDir.

[Robert Sesek, 2014/12/30 17:02:21]

Done.

+    EXPECT_GE(tmp.get(), 0) << errno;

[Mark Mentovai, 2014/12/19 23:16:32]

#include "util/test/errros.h" and use << ErrnoMessage("open");

Similar on line 41.

[Robert Sesek, 2014/12/30 17:02:21]

Done.

+  }
+
+  void TearDown() override {
+    EXPECT_EQ(0, unlink(path_.value().c_str())) << errno;
+  }
+
+  base::FilePath path() { return path_; }
+
+ private:
+  base::FilePath path_;
+};
+
+const char kKey[] = "com.google.crashpad.test";
+
+TEST_F(Xattr, ReadNonExistentXattr) {
+  std::string value;
+  EXPECT_FALSE(ReadXattr(path(), kKey, &value));
+}
+
+TEST_F(Xattr, WriteAndReadString) {
+  std::string value = "hello world";
+  EXPECT_TRUE(WriteXattr(path(), kKey, value));
+
+  std::string actual;
+  EXPECT_TRUE(ReadXattr(path(), kKey, &actual));
+  EXPECT_EQ(value, actual);
+}
+
+TEST_F(Xattr, WriteAndReadVeryLongString) {
+  std::string value(512, 'A');

[Mark Mentovai, 2014/12/19 23:16:32]

Maybe a not-power-of-2-aligned-length string?

[Robert Sesek, 2014/12/30 17:02:21]

Done.

+  EXPECT_TRUE(WriteXattr(path(), kKey, value));
+
+  std::string actual;
+  EXPECT_TRUE(ReadXattr(path(), kKey, &actual));
+  EXPECT_EQ(value, actual);
+}
+
+TEST_F(Xattr, WriteAndReadBool) {
+  EXPECT_TRUE(WriteXattrBool(path(), kKey, true));
+  bool actual = false;
+  EXPECT_TRUE(ReadXattrBool(path(), kKey, &actual));
+  EXPECT_TRUE(actual);
+
+  EXPECT_TRUE(WriteXattrBool(path(), kKey, false));
+  EXPECT_TRUE(ReadXattrBool(path(), kKey, &actual));
+  EXPECT_FALSE(actual);
+}
+
+TEST_F(Xattr, WriteAndReadInt) {
+  int expected = 42;
+  int actual;
+
+  EXPECT_TRUE(WriteXattrInt(path(), kKey, expected));
+  EXPECT_TRUE(ReadXattrInt(path(), kKey, &actual));
+  EXPECT_EQ(expected, actual);
+
+  expected = std::numeric_limits<int>::max();
+  EXPECT_TRUE(WriteXattrInt(path(), kKey, expected));
+  EXPECT_TRUE(ReadXattrInt(path(), kKey, &actual));
+  EXPECT_EQ(expected, actual);
+}
+
+TEST_F(Xattr, WriteAndReadTimeT) {
+  time_t expected = time(nullptr);
+  time_t actual;
+
+  EXPECT_TRUE(WriteXattrTimeT(path(), kKey, expected));
+  EXPECT_TRUE(ReadXattrTimeT(path(), kKey, &actual));
+  EXPECT_EQ(expected, actual);
+
+  expected = std::numeric_limits<time_t>::max();
+  EXPECT_TRUE(WriteXattrTimeT(path(), kKey, expected));
+  EXPECT_TRUE(ReadXattrTimeT(path(), kKey, &actual));
+  EXPECT_EQ(expected, actual);
+}
+
+}  // namespace
+}  // namespace test
+}  // namespace crashpad